[Flang][OpenMP] Port OpenMP single tests to hlfir flow #69877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
flang
kiranchandramohan
changed the title
kiranchandramohan
approved these changes
Oct 23, 2023
flang/test/Lower/OpenMP/single.f90
Outdated
| !CHECK: omp.parallel | ||
| !$omp parallel | ||
| !CHECK: omp.single | ||
| !$omp single | ||
| !CHECK: %[[xval:.*]] = fir.load %[[x]] : !fir.ref<i32> | ||
| !CHECK: %[[xval:.*]] = fir.load %[[X_DECL]]#0 : !fir.ref<i32> |
There was a problem hiding this comment.
Nit: keep the alignment.
flang/test/Lower/OpenMP/single.f90
Outdated
Comment on lines
83
to
86
| ! CHECK: %[[Y_DECL:.*]]:2 = hlfir.declare %[[Y]] {uniq_name = "_QFsingle_privatizationEy"} : (!fir.ref<f64>) -> (!fir.ref<f64>, !fir.ref<f64>) | ||
| ! CHECK: %[[VAL_6:.*]] = fir.load %[[VAL_1_DECL]]#1 : !fir.ref<f64> | ||
| ! CHECK: fir.store %[[VAL_6]] to %[[Y_DECL]]#1 : !fir.ref<f64> | ||
| ! CHECK: fir.call @_QPbar(%[[X_DECL]]#1, %[[Y_DECL]]#1) fastmath<contract> : (!fir.ref<f32>, !fir.ref<f64>) -> () |
There was a problem hiding this comment.
Nit: Maintain the alignment.
flang/test/Lower/OpenMP/single.f90
Outdated
| !=============================================================================== | ||
|
|
||
| !CHECK-LABEL: func @_QPomp_single | ||
| !CHECK-SAME: (%[[x:.*]]: !fir.ref<i32> {fir.bindc_name = "x"}) |
There was a problem hiding this comment.
Nit: Change x to a capital X, here and elsewhere.
flang/test/Lower/OpenMP/single.f90
Outdated
Comment on lines
108
to
109
| ! CHECK: %[[X:.*]] = fir.alloca f32 {bindc_name = "x", pinned, uniq_name = "_QFsingle_privatization2Ex"} | ||
| ! CHECK: %[[X_DECL:.*]]:2 = hlfir.declare %[[X]] {uniq_name = "_QFsingle_privatization2Ex"} : (!fir.ref<f32>) -> (!fir.ref<f32>, !fir.ref<f32>) |
There was a problem hiding this comment.
Nit: Better to call these as X_PVT, X_PVT_DECL.
flang/test/Lower/OpenMP/single.f90
Outdated
Comment on lines
104
to
105
| ! CHECK: %[[VAL_0_DECL:.*]]:2 = hlfir.declare %[[VAL_0]] {uniq_name = "_QFsingle_privatization2Ex"} : (!fir.ref<f32>) -> (!fir.ref<f32>, !fir.ref<f32>) | ||
| ! CHECK: %[[VAL_1_DECL:.*]]:2 = hlfir.declare %[[VAL_1]] {uniq_name = "_QFsingle_privatization2Ey"} : (!fir.ref<f64>) -> (!fir.ref<f64>, !fir.ref<f64>) |
There was a problem hiding this comment.
Nit: Better to call these as X and X_DECL.
kiranchandramohan
approved these changes
Oct 24, 2023
|
This current merge created a check-flang failure. A Fix(#70164) will be merged shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.