Skip to content

[llvm][TableGen] Add a README to the main TableGen folder #69943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

DavidSpickett
Copy link
Collaborator

Though I doubt that many people will land here directly, I thought it odd that we didn't have one.

The intro I've copied from the programmer's reference and added a simple example. Then some links to resources and tools, which is the main reason to have this page.

Though I doubt that many people will land here directly, I
thought it odd that we didn't have one.

The intro I've copied from the programmer's reference and
added a simple example. Then some links to resources and tools,
which is the main reason to have this page.
@DavidSpickett
Copy link
Collaborator Author

@joker-eph do you know if there's any other MLIR tablegen things worth mentioning? I've just linked to the LSP server for now. Maybe MLIR has a better page than that I should link instead.

@joker-eph
Copy link
Collaborator

We have our ODS definition docs: https://mlir.llvm.org/docs/DefiningDialects/AttributesAndTypes/ and https://mlir.llvm.org/docs/DefiningDialects/Operations/

This isn't generic "TableGen" but your "Resources for learning the language" aren't all generic either I believe (by the way should this be curated and split into "TableGen" vs "some TableGen backends"?)

@DavidSpickett
Copy link
Collaborator Author

(by the way should this be curated and split into "TableGen" vs "some TableGen backends"?)

Yes, I see the two conflated all the time and fell into the trap myself.

@DavidSpickett
Copy link
Collaborator Author

Added the MLIR links and split language and backend resources.

TableGen is live in Compiler Explorer now, but I haven't added a "trunk" variant yet. So I'll add links for that in a follow up when that's there.

Copy link
Member

@mshockwave mshockwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty neat! LGTM w/ a minor comment.

TableGen is live in Compiler Explorer now, but I haven't added a "trunk" variant yet. So I'll add links for that in a follow up when that's there.

Please do! CE is easily approachable for most people.

@DavidSpickett DavidSpickett merged commit b81bfea into llvm:main Oct 25, 2023
@DavidSpickett DavidSpickett deleted the llvm-tblgen-readme branch October 25, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants