Fix WebKit static analyzers to support ref and deref methods to be defined on different classes. #69985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
rniwa
force-pushed
the
fix-webkit-ref-deref-on-diff-classes
branch
from
d823635 to
1832737
Compare
|
LGTM, thanks!! I have a couple nitpicks but I don't think they should block your progress. |
haoNoQ
approved these changes
Nov 9, 2023
clang/lib/StaticAnalyzer/Checkers/WebKit/RefCntblBaseVirtualDtorChecker.cpp
Outdated
Show resolved
Hide resolved
| @@ -77,14 +77,53 @@ class RefCntblBaseVirtualDtorChecker | |||
| (AccSpec == AS_none && RD->isClass())) | |||
| return false; | |||
|
|
|||
| std::optional<const CXXRecordDecl*> RefCntblBaseRD = isRefCountable(Base); | |||
| if (!RefCntblBaseRD || !(*RefCntblBaseRD)) | |||
| auto hasRefInBase = clang::hasPublicMethodInBase(Base, "ref"); | |||
There was a problem hiding this comment.
I wonder if this entire new section can be deduplicated with isRefCountable() in the other file. They look so similar!
|
(You still need me to merge right? You can ask me to merge, or you can address nitpicks and then ask me to merge, or you can go through https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access and merge yourself!) |
…fined on different classes.
rniwa
force-pushed
the
fix-webkit-ref-deref-on-diff-classes
branch
from
1832737 to
bf169f3
Compare
|
Yes, it would be great if you can merge the change now that I've addressed your nits. |
zahiraam
pushed a commit
to zahiraam/llvm-project
that referenced
this pull request
Nov 20, 2023
…fined on different classes. (llvm#69985)
haoNoQ
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Dec 16, 2023
…fined on different classes. (llvm#69985) (cherry picked from commit 09273d4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.