Skip to content

[MLIR][pass registry] show overlapping pass pipeline name #70167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2023
Merged

[MLIR][pass registry] show overlapping pass pipeline name #70167

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f56ab9b
[MLIR][pass registry] show overlapping pass
makslevental Oct 25, 2023
585e6ad
reorder headers to match convention
makslevental Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions mlir/lib/Pass/PassRegistry.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,20 @@
//
//===----------------------------------------------------------------------===//

#include <optional>
#include <utility>
#include "mlir/Pass/PassRegistry.h"

#include "mlir/Pass/Pass.h"
#include "mlir/Pass/PassManager.h"
#include "mlir/Pass/PassRegistry.h"
#include "llvm/ADT/DenseMap.h"
#include "llvm/ADT/ScopeExit.h"
#include "llvm/Support/Format.h"
#include "llvm/Support/ManagedStatic.h"
#include "llvm/Support/MemoryBuffer.h"
#include "llvm/Support/SourceMgr.h"

#include <optional>
#include <utility>

using namespace mlir;
using namespace detail;

Expand Down Expand Up @@ -99,7 +100,10 @@ void mlir::registerPassPipeline(
PassPipelineInfo pipelineInfo(arg, description, function,
std::move(optHandler));
bool inserted = passPipelineRegistry->try_emplace(arg, pipelineInfo).second;
assert(inserted && "Pass pipeline registered multiple times");
#ifndef NDEBUG
if (!inserted)
report_fatal_error("Pass pipeline " + arg + " registered multiple times");
#endif
(void)inserted;
}

Expand Down