Skip to content

[LoongArch] Fix ABI mismatch with gcc/g++ about empty structs passing #70320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2023
Merged

[LoongArch] Fix ABI mismatch with gcc/g++ about empty structs passing #70320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions clang/lib/CodeGen/Targets/LoongArch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,12 +308,14 @@ ABIArgInfo LoongArchABIInfo::classifyArgumentType(QualType Ty, bool IsFixed,
CGCXXABI::RAA_DirectInMemory);
}

// Ignore empty structs/unions.
if (isEmptyRecord(getContext(), Ty, true))
return ABIArgInfo::getIgnore();

uint64_t Size = getContext().getTypeSize(Ty);

// Ignore empty struct or union whose size is zero, e.g. `struct { }` in C or
// `struct { int a[0]; }` in C++. In C++, `struct { }` is empty but it's size
// is 1 byte and g++ doesn't ignore it; clang++ matches this behaviour.
if (isEmptyRecord(getContext(), Ty, true) && Size == 0)
return ABIArgInfo::getIgnore();

// Pass floating point values via FARs if possible.
if (IsFixed && Ty->isFloatingType() && !Ty->isComplexType() &&
FRLen >= Size && FARsLeft) {
Expand Down
8 changes: 4 additions & 4 deletions clang/test/CodeGen/LoongArch/abi-lp64d-empty-structs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ struct s9 test_s9(struct s9 a) {
}

// CHECK-C: define{{.*}} void @test_s10()
// CHECK-CXX: define{{.*}} void @_Z8test_s103s10()
// CHECK-CXX: define{{.*}} i64 @_Z8test_s103s10(i64 {{.*}})
struct s10 { };
struct s10 test_s10(struct s10 a) {
return a;
Expand Down Expand Up @@ -128,14 +128,14 @@ struct s14 test_s14(struct s14 a) {
}

// CHECK-C: define{{.*}} void @test_s15()
// CHECK-CXX: define{{.*}} void @_Z8test_s153s15()
// CHECK-CXX: define{{.*}} i64 @_Z8test_s153s15(i64 {{.*}})
struct s15 { int : 0; };
struct s15 test_s15(struct s15 a) {
return a;
}

// CHECK-C: define{{.*}} void @test_s16()
// CHECK-CXX: define{{.*}} void @_Z8test_s163s16()
// CHECK-C: define{{.*}} i64 @test_s16(i64 {{.*}})
// CHECK-CXX: define{{.*}} i64 @_Z8test_s163s16(i64 {{.*}})
struct s16 { int : 1; };
struct s16 test_s16(struct s16 a) {
return a;
Expand Down