[Clang][Docs] use CommonOptionsParser::create instead of protected constructor on libTooling tutorial (NFC)

[khei4]

This patch fixes the code example on CommonOptionParser on https://intel.github.io/llvm-docs/clang/LibTooling.html

CommonOptionParser's constructor is protected, and we can use CommonOptionParser::create instead of that.
It seems like the LibASTMatcher tutorial already uses that. https://clang.llvm.org/docs/LibASTMatchersTutorial.html

[llvmbot]

@llvm/pr-subscribers-clang

Author: Kohei Asano (khei4)

Changes

This patch fixes the code example on CommonOptionParser on https://intel.github.io/llvm-docs/clang/LibTooling.html

CommonOptionParser's constructor is protected and we can use CommonOptionParser::create instead of that.

I'm still not so sure whether other old examples are around there.

---

Full diff: https://github.com/llvm/llvm-project/pull/70427.diff

1 Files Affected:

• (modified) clang/docs/LibTooling.rst (+1-1)

diff --git a/clang/docs/LibTooling.rst b/clang/docs/LibTooling.rst
index df50dcebf9b83c7..cf0e0d005f45e16 100644
--- a/clang/docs/LibTooling.rst
+++ b/clang/docs/LibTooling.rst
@@ -71,7 +71,7 @@ and automatic location of the compilation database using source files paths.
   int main(int argc, const char **argv) {
     // CommonOptionsParser constructor will parse arguments and create a
     // CompilationDatabase.  In case of error it will terminate the program.
-    CommonOptionsParser OptionsParser(argc, argv, MyToolCategory);
+    auto OptionsParser = CommonOptionsParser::create(argc, argv, MyToolCategory);
 
     // Use OptionsParser.getCompilations() and OptionsParser.getSourcePathList()
     // to retrieve CompilationDatabase and the list of input file paths.

[Xulei-NL]

Nice that the author has created this PR for fixing the inconsistent LibTooling document. This PR is very important to clang LibTooling beginners. Could the reviewers please approve it soon? 😃

[Sirraide]

LGTM except for one minor issue.