[NFC] Extract LoopConstrainer from IRCE to reuse it outside the pass #70508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleks-tmb
requested review from
danilaml,
DaniilSuchkov,
arpilipe and
annamthomas
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
aleks-tmb
force-pushed
the
loop-constrainer
branch
from
171be67 to
f04a24d
Compare
danilaml
approved these changes
Oct 30, 2023
added 8 commits
October 31, 2023 07:59
Preparatory patch for extracting LoopConstrainer to a separate file to reuse it outside IRCE. Move ExitCountTy out of the LoopConstrainer to avoid MaxBETakenCount recalculation.
…oopStructure Preparatory patch for extracting LoopConstrainer to a separate file to reuse it outside IRCE. Remove LoopStructure's dependency on the AllowUnsignedLatchCondition option.
Preparatory patch for extracting LoopConstrainer to a separate file to reuse it outside IRCE. Move the specific for IRCE calculateSubRanges method outside of LoopConstrainer.
Preparatory patch for extracting LoopConstrainer to a separate file to reuse it outside IRCE. Replace InductiveRangeCheck::Range typed field by Type* one.
Preparatory patch for extracting LoopConstrainer to a separate file to reuse it outside IRCE.
Preparatory patch for extracting LoopConstrainer to a separate file to reuse it outside IRCE.
Preparatory patch for extracting LoopConstrainer to a separate file to reuse it outside IRCE.
Extract LoopConstrainer to a separate file to reuse it outside IRCE.
aleks-tmb
force-pushed
the
loop-constrainer
branch
from
f04a24d to
a5cf18d
Compare
|
fyi, there's no need to touch gn files if you're not using them (this patch actually broke the gn build and the gn file list auto-updater due to a missing comma) |
Got it, sorry. Thanks for fixing that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.