[objcopy] Implement --weaken, --weaken-symbol(s) flags for MachO Object Files #70560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danzimm
force-pushed
the
llvm-objcopy-macho-weaken
branch
from
125fdd4 to
9456cd8
Compare
alexander-shaposhnikov
requested review from
alexander-shaposhnikov and
MaskRay
|
Thanks for reviewing! I don't have write access- can you merge this for me? |
MaskRay
approved these changes
Nov 1, 2023
MaskRay
reviewed
Nov 1, 2023
|
Let's address @MaskRay's comments - then i'm happy to merge it in |
danzimm
force-pushed
the
llvm-objcopy-macho-weaken
branch
from
9456cd8 to
92b0389
Compare
|
I think I've addressed everything now-- feel free to leave extra comments, though! Thanks everyone for the help! |
alexander-shaposhnikov
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a recent legacy codebase I found an invocation of GNU
objconvused to weaken symbols of MachO object files. I tried to replaceobjconvwith the corresponding invocation ofllvm-objcopyand found--weaken(and friends) weren't implemented for MachO.This PR implements those weakening flags for MachO file types.