Skip to content

[OpenMP] Directly use user's grid and block size in kernel language mode #70612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,9 @@ struct GenericKernelTy {

/// The prototype kernel launch environment.
KernelLaunchEnvironmentTy KernelLaunchEnvironment;

/// If the kernel is a bare kernel.
bool IsBareKernel = false;
};

/// Class representing a map of host pinned allocations. We track these pinned
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -436,6 +436,7 @@ Error GenericKernelTy::init(GenericDeviceTy &GenericDevice,
Name, ErrStr.data());
assert(KernelEnvironment.Configuration.ReductionDataSize == 0 &&
"Default initialization failed.");
IsBareKernel = true;
}

// Max = Config.Max > 0 ? min(Config.Max, Device.Max) : Device.Max;
Expand Down Expand Up @@ -594,6 +595,10 @@ uint32_t GenericKernelTy::getNumThreads(GenericDeviceTy &GenericDevice,
uint32_t ThreadLimitClause[3]) const {
assert(ThreadLimitClause[1] == 0 && ThreadLimitClause[2] == 0 &&
"Multi dimensional launch not supported yet.");

if (IsBareKernel && ThreadLimitClause[0] > 0)
return ThreadLimitClause[0];

if (ThreadLimitClause[0] > 0 && isGenericMode())
ThreadLimitClause[0] += GenericDevice.getWarpSize();

Expand All @@ -610,6 +615,9 @@ uint64_t GenericKernelTy::getNumBlocks(GenericDeviceTy &GenericDevice,
assert(NumTeamsClause[1] == 0 && NumTeamsClause[2] == 0 &&
"Multi dimensional launch not supported yet.");

if (IsBareKernel && NumTeamsClause[0] > 0)
return NumTeamsClause[0];

if (NumTeamsClause[0] > 0) {
// TODO: We need to honor any value and consequently allow more than the
// block limit. For this we might need to start multiple kernels or let the
Expand Down
38 changes: 38 additions & 0 deletions openmp/libomptarget/test/offloading/ompx_bare.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
// RUN: %libomptarget-compile-generic
// RUN: env LIBOMPTARGET_INFO=63 %libomptarget-run-generic 2>&1 | %fcheck-generic
//
// UNSUPPORTED: x86_64-pc-linux-gnu
// UNSUPPORTED: x86_64-pc-linux-gnu-LTO
// UNSUPPORTED: aarch64-unknown-linux-gnu
// UNSUPPORTED: aarch64-unknown-linux-gnu-LTO

#include <assert.h>
#include <ompx.h>
#include <stdio.h>
#include <stdlib.h>

int main(int argc, char *argv[]) {
const int num_blocks = 64;
const int block_size = 64;
const int N = num_blocks * block_size;
int *data = (int *)malloc(N * sizeof(int));

// CHECK: "PluginInterface" device 0 info: Launching kernel __omp_offloading_{{.*}} with 64 blocks and 64 threads in SPMD mode

#pragma omp target teams ompx_bare num_teams(num_blocks) thread_limit(block_size) map(from: data[0:N])
{
int bid = ompx_block_id_x();
int bdim = ompx_block_dim_x();
int tid = ompx_thread_id_x();
int idx = bid * bdim + tid;
data[idx] = idx;
}

for (int i = 0; i < N; ++i)
assert(data[i] == i);

// CHECK: PASS
printf("PASS\n");

return 0;
}