libcxx: remove redundant <cstdint> include from <string> #70613
Conversation
It looks like this has been there for so long that my git-blaming ran into the end of history when libc++ was imported from svn in 2010. This change will undoubtedly break some downstream code with broken includes, but libstdc++ does not do the same here, so such code was already broken on libstdc++.
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: Jade Lovelace (lf-) ChangesIt looks like this has been there for so long that my git-blaming ran into the end of history when libc++ was imported from svn in 2010. This change will undoubtedly break some downstream code with broken includes, but libstdc++ does not do the same here, so such code was already broken on libstdc++; as such this change improves compatibility between the two implementations. Full diff: https://github.com/llvm/llvm-project/pull/70613.diff 1 Files Affected:
diff --git a/libcxx/include/string b/libcxx/include/string
index cf9f0c847eb43af..68f13414c7b6948 100644
--- a/libcxx/include/string
+++ b/libcxx/include/string
@@ -614,7 +614,6 @@ basic_string<char32_t> operator""s( const char32_t *str, size_t len );
#include <__utility/swap.h>
#include <__utility/unreachable.h>
#include <climits>
-#include <cstdint>
#include <cstdio> // EOF
#include <cstring>
#include <limits>
|
|
It looks like |
|
Why is the include redundant? We don't use anything from |
Nothing that I could find. If we did, the modules build should also have complained. |
It looks like this has been there for so long that my git-blaming ran into the end of history when libc++ was imported from svn in 2010. This change will undoubtedly break some downstream code with broken includes, but libstdc++ does not do the same here, so such code was already broken on libstdc++; as such this change improves compatibility between the two implementations.