[compiler-rt] Don't link builtins against the CRT on Windows #70675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstorsjo
reviewed
Oct 30, 2023
| @@ -761,6 +761,12 @@ else () | |||
|
|
|||
| append_list_if(COMPILER_RT_HAS_STD_C11_FLAG -std=c11 BUILTIN_CFLAGS) | |||
|
|
|||
| # Don't link the the CRT on Windows | |||
There was a problem hiding this comment.
I'd prefer to clarify the terminology here a bit; the builtins is a static library, so we're not linking anything anyway. Perhaps # Don't embed directives for picking any specific CRT?
There was a problem hiding this comment.
I made this change in my rebase before merging
zmodem
approved these changes
Oct 31, 2023
compiler-rt/builtins doesn't depend on anything from the CRT but currently links against it and embeds a `/defaultlib:msvcrt` in the `.lib` file, forcing anyone linking against it to also link against that specific CRT. This isn't necessary as the end user can just choose which CRT they want to use independently.
DavidTruby
force-pushed
the
builtins-crt
branch
from
97ec980 to
2c8bcc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compiler-rt/builtins doesn't depend on anything from the CRT but
currently links against it and embeds a
/defaultlib:msvcrtin the.libfile, forcing anyone linking against it to also link against thatspecific CRT. This isn't necessary as the end user can just choose which
CRT they want to use independently.