Skip to content

[OpenMP] Add a test for D158802 #70678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2023
Merged

[OpenMP] Add a test for D158802 #70678

merged 1 commit into from
Oct 30, 2023

Conversation

shiltian
Copy link
Contributor

In D158802 we honored user's thread_limit value even with the optimization
introduced in D152014. This patch adds a simple test.

@llvmbot llvmbot added the openmp:libomptarget OpenMP offload runtime label Oct 30, 2023
@shiltian shiltian requested a review from jdoerfert October 30, 2023 16:07
jdoerfert
jdoerfert approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@jdoerfert jdoerfert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disable it on the CPU or lower the thread count, otherwise this will fail

@shiltian
[OpenMP] Add a test for D158802
21e68ca 
In D158802 we honored user's `thread_limit` value even with the optimization
introduced in D152014. This patch adds a simple test.
@shiltian shiltian merged commit 0d5b7dd into llvm:main Oct 30, 2023
@shiltian shiltian deleted the add-test branch October 30, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdoerfert jdoerfert jdoerfert approved these changes

Assignees
No one assigned
Labels
openmp:libomptarget OpenMP offload runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shiltian @jdoerfert @llvmbot