Skip to content

[PowerPC] Change registers used in test due to ABI breakage. NFC. #70758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 2, 2023
Merged

[PowerPC] Change registers used in test due to ABI breakage. NFC. #70758

merged 4 commits into from
Nov 2, 2023

Conversation

bzEq
Copy link
Collaborator

@bzEq bzEq commented Oct 31, 2023 •
edited
Loading

Usage of r30 and r31 has broken current traceback table's convention on AIX. Avoid using CSRs in livein list.

@bzEq bzEq self-assigned this Oct 31, 2023
@bzEq bzEq changed the title [PowerPC] Change triple due to AIX ABI breakage. NFC. [PowerPC] Change triple of test due to AIX ABI breakage. NFC. Oct 31, 2023
@bzEq bzEq changed the title [PowerPC] Change triple of test due to AIX ABI breakage. NFC. [PowerPC] Change registers used due to ABI breakage. NFC. Oct 31, 2023
@bzEq bzEq changed the title [PowerPC] Change registers used due to ABI breakage. NFC. [PowerPC] Change registers used in test due to ABI breakage. NFC. Oct 31, 2023
chenzheng1030
chenzheng1030 approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@chenzheng1030 chenzheng1030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

maryammo
maryammo reviewed Oct 31, 2023
View reviewed changes
Copy link
Contributor

@maryammo maryammo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, LGTM.

@maryammo maryammo self-requested a review October 31, 2023 23:07
@maryammo maryammo mentioned this pull request Nov 2, 2023
Merged
@maryammo
Copy link
Contributor

maryammo commented Nov 2, 2023

@bzEq, Can this be merged?
#71115 depends on this PR to pass. Thanks.

@bzEq bzEq merged commit 7b5505b into llvm:main Nov 2, 2023
@bzEq bzEq deleted the alter-triple branch November 22, 2023 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenzheng1030 chenzheng1030 chenzheng1030 approved these changes

@maryammo maryammo maryammo approved these changes

@ecnelises ecnelises Awaiting requested review from ecnelises

Assignees

@bzEq bzEq

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzEq @maryammo @chenzheng1030