Skip to content

Fix to attribute plugins reaching an unreachable #70877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Fix to attribute plugins reaching an unreachable #70877

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e24ee9c
Fix attribute plugins
amykhuang Oct 31, 2023
c75681d
clang-format
amykhuang Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions clang/lib/Sema/ParsedAttr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,9 +193,18 @@ bool ParsedAttr::isTypeAttr() const { return getInfo().IsType; }
bool ParsedAttr::isStmtAttr() const { return getInfo().IsStmt; }

bool ParsedAttr::existsInTarget(const TargetInfo &Target) const {
return getInfo().existsInTarget(Target) &&
getInfo().spellingExistsInTarget(Target,
getAttributeSpellingListIndex());
Kind K = getParsedKind();

// If the attribute has a target-specific spelling, check that it exists.
// Only call this if the attr is not ignored/unknown. For most targets, this
// function just returns true.
bool HasSpelling = K != IgnoredAttribute && K != UnknownAttribute &&
K != NoSemaHandlerAttribute;
bool TargetSpecificSpellingExists =
!HasSpelling ||
getInfo().spellingExistsInTarget(Target, getAttributeSpellingListIndex());

return getInfo().existsInTarget(Target) && TargetSpecificSpellingExists;
}

bool ParsedAttr::isKnownToGCC() const { return getInfo().IsKnownToGCC; }
Expand Down