[flang ]GETLOG runtime and extension implementation: get login username #70917

yiwu0b11 · 2023-11-01T10:07:47Z

Get login username, ussage:

CHARACTER(32) :: login
CALL getlog(login)
WRITE(*,*) login

getlog is required for an exascale proxyapp.
https://proxyapps.exascaleproject.org/app/minismac2d/
https://github.com/Mantevo/miniSMAC/blob/f90446714226eeef650b78bce06ca4967792e74d/ref/smac2d.f#L615
https://github.com/Mantevo/miniSMAC/blob/f90446714226eeef650b78bce06ca4967792e74d/ref/smac2d.f#L1570

Signed-off-by: Jeff Hammond <[email protected]>

github-actions · 2023-11-01T10:19:58Z

✅ With the latest revision this PR passed the C/C++ code formatter.

DavidTruby

LGTM with a few small comments. Please wait for @jeanPerier to approve before merging.

flang/runtime/extensions.cpp

jeanPerier

Thanks a lot for the update and addressing my previous comments!

flang/runtime/extensions.cpp

…_line' into execute_command_line

jeanPerier

LGTM, thanks for addressing all my comments!

yiwu0b11 · 2023-11-21T12:50:39Z

Hello @klausler, could you please share your thoughts or comments on this patch, particularly with regard to the Windows side? Thanks in advance.

klausler · 2023-11-21T19:31:23Z

Hello @klausler, could you please share your thoughts or comments on this patch, particularly with regard to the Windows side? Thanks in advance.

You should use modern C++ braced initialization in flang/runtime.

flang/runtime/extensions.cpp

…dows

exitstat: If sync, assigned processor-dependent exit status. Otherwise unchanged. cmdstast: Assigned 0 as specifed in standard, if error then overwrite. If a condition occurs that would assign a nonzero value to CMDSTAT but the CMDSTAT variable is not present, error termination is initiated.

yiwu0b11 · 2023-11-27T12:44:40Z

Hello @klausler, could you please share your thoughts or comments on this patch, particularly with regard to the Windows side? Thanks in advance.

You should use modern C++ braced initialization in flang/runtime.

Hi @klausler. Thanks for the comment! I have updated the runtime file with variables being braced initialized. Any other things that I should be aware of? Thanks in advance.

flang/include/flang/Runtime/time-intrinsic.h

Work and test on Linux, both sync and async mode. Sync mode: termination will terminate directly Async mode: will only terminate the child/async process, no effect on parent Standard: If a condition occurs that would assign a nonzero value to CMDSTAT, but the CMDSTAT variable is not present, error termination is initiated.

yiwu0b11 · 2023-12-04T12:28:27Z

Hi @klausler, thanks for the comment, I have changed the initial letters and add const to buffer in function declaration. Is there anything else I should pay attention to? Thanks in advance!

klausler · 2023-12-04T16:10:13Z

flang/docs/Intrinsics.md

@@ -751,7 +751,7 @@ This phase currently supports all the intrinsic procedures listed above but the
 | Object characteristic inquiry functions | ALLOCATED, ASSOCIATED, EXTENDS_TYPE_OF, IS_CONTIGUOUS, PRESENT, RANK, SAME_TYPE, STORAGE_SIZE |
 | Type inquiry intrinsic functions | BIT_SIZE, DIGITS, EPSILON, HUGE, KIND, MAXEXPONENT, MINEXPONENT, NEW_LINE, PRECISION, RADIX, RANGE, TINY|
 | Non-standard intrinsic functions | AND, OR, XOR, SHIFT, ZEXT, IZEXT, COSD, SIND, TAND, ACOSD, ASIND, ATAND, ATAN2D, COMPL, EQV, NEQV, INT8, JINT, JNINT, KNINT, QCMPLX, DREAL, DFLOAT, QEXT, QFLOAT, QREAL, DNUM, NUM, JNUM, KNUM, QNUM, RNUM, RAN, RANF, ILEN, SIZEOF, MCLOCK, SECNDS, COTAN, IBCHNG, ISHA, ISHC, ISHL, IXOR, IARG, IARGC, NARGS, GETPID, NUMARG, BADDRESS, IADDR, CACHESIZE, EOF, FP_CLASS, INT_PTR_KIND, ISNAN, MALLOC |
-| Intrinsic subroutines |MVBITS (elemental), CPU_TIME, DATE_AND_TIME, EVENT_QUERY, EXECUTE_COMMAND_LINE, GET_COMMAND, GET_COMMAND_ARGUMENT, GET_ENVIRONMENT_VARIABLE, MOVE_ALLOC, RANDOM_INIT, RANDOM_NUMBER, RANDOM_SEED, SYSTEM_CLOCK |
+| Intrinsic subroutines |MVBITS (elemental), CPU_TIME, DATE_AND_TIME, EVENT_QUERY, EXECUTE_COMMAND_LINE, GET_COMMAND, GET_COMMAND_ARGUMENT, GET_ENVIRONMENT_VARIABLE, GETLOG, MOVE_ALLOC, RANDOM_INIT, RANDOM_NUMBER, RANDOM_SEED, SYSTEM_CLOCK |


You are not really implementing GETLOG here as an intrinsic subroutine, but as a library subroutine. (There is no interface exposed to user programs in the intrinsic procedure tables.)

Should I create a new row in this markdown table called Library subroutine?

flang/runtime/extensions.cpp

flang/runtime/time-intrinsic.cpp

signal(SIGCHLD, SIG_IGN); https://man7.org/linux/man-pages/man2/sigaction.2.html POSIX.1-1990 disallowed setting the action for SIGCHLD to SIG_IGN. POSIX.1-2001 and later allow this possibility, so that ignoring SIGCHLD can be used to prevent the creation of zombies (see wait(2)). Nevertheless, the historical BSD and System V behaviors for ignoring SIGCHLD differ, so that the only completely portable method of ensuring that terminated children do not become zombies is to catch the SIGCHLD signal and perform a wait(2) or similar.

yiwu0b11 · 2023-12-06T17:03:59Z

CI didn't pass because getlogin_r fail on Linux with error code 6.

ENXIO
The calling process has no controlling terminal.

https://man.archlinux.org/man/getlogin_r.3.en#EMFILE suggested using environment variable rather than use getlogin or getlogin_r.
Thus, the implementation of getlog intrinsics has changed: get username by calling GetEnvVriable runtime function.
On WIndows, use environment variable USERNAME.
On Linux, use environment variable LOGNAME.

klausler · 2023-12-06T17:11:04Z

The environment is easy to spoof; perhaps you should use it only if there's no login terminal.

yiwu0b11 · 2023-12-06T17:15:32Z

oh my..., I push the execute_command_line branch here.

jeffhammond added 12 commits October 18, 2023 15:12

add execute_command_line

49da4a6

Signed-off-by: Jeff Hammond <[email protected]>

this is definitely not completely correct

e31c6f3

definitely not right either

60a826e

definitely not right either

aa31e9b

more correct

a417c5a

more correct

36811c7

remove trailing space

6cc9e3f

5 args not 6

46664b7

i have no idea what i am doing

01d6167

runtime part of this

b6ea7a7

WIP

7ffafe4

where is the pattern for IsValidLogicalDescriptor

2e9685b

yiwu0b11 force-pushed the getlog branch 14 times, most recently from cdae515 to ce001f3 Compare November 9, 2023 14:33

kiranchandramohan requested review from DavidTruby, jeanPerier and klausler November 9, 2023 14:38

DavidTruby approved these changes Nov 14, 2023

View reviewed changes

flang/runtime/extensions.cpp Outdated Show resolved Hide resolved

flang/runtime/extensions.cpp Outdated Show resolved Hide resolved

flang/runtime/extensions.cpp Outdated Show resolved Hide resolved

flang/runtime/extensions.cpp Outdated Show resolved Hide resolved

jeanPerier reviewed Nov 15, 2023

View reviewed changes

flang/runtime/extensions.cpp Outdated Show resolved Hide resolved

flang/runtime/extensions.cpp Outdated Show resolved Hide resolved

flang/runtime/extensions.cpp Outdated Show resolved Hide resolved

yiwu0b11 force-pushed the getlog branch from 5f513f3 to a1b1b66 Compare November 15, 2023 14:12

yiwu0b11 mentioned this pull request Nov 15, 2023

[flang] FDATE extension implementation: get date and time in ctime format #71222

Merged

Merge remote-tracking branch 'jeffhammond/jeffhammond-execute_command…

02ab9c8

…_line' into execute_command_line

jeanPerier approved these changes Nov 20, 2023

View reviewed changes

some small fixes to make it build

df35e09

kiranchandramohan reviewed Nov 22, 2023

View reviewed changes

flang/runtime/extensions.cpp Outdated Show resolved Hide resolved

flang/runtime/extensions.cpp Outdated Show resolved Hide resolved

yiwu0b11 added 2 commits November 23, 2023 15:49

Add simple support of async and sync execution, might not work on Win…

94ac475

…dows

klausler reviewed Nov 27, 2023

View reviewed changes

flang/include/flang/Runtime/time-intrinsic.h Outdated Show resolved Hide resolved

flang/include/flang/Runtime/time-intrinsic.h Outdated Show resolved Hide resolved

yiwu0b11 and others added 6 commits November 28, 2023 14:29

Added EXECL_ERR if exit==-1, update docs

7ef735f

Add runtime tests

1b17b28

Add lowering intrinsic tests

521228c

add more docs, format, and brace initialization

f7133e4

add test fixes on Windows and remove address_of in testing

c8e2e00

klausler reviewed Dec 4, 2023

View reviewed changes

yiwu0b11 force-pushed the getlog branch from 3ac03a6 to af9294c Compare December 6, 2023 17:11

yiwu0b11 closed this Dec 6, 2023

yiwu0b11 deleted the getlog branch December 6, 2023 17:12

yiwu0b11 mentioned this pull request Dec 6, 2023

[flang] GETLOG runtime and extension implementation: get login username #74628

Merged

[flang ]GETLOG runtime and extension implementation: get login username #70917

[flang ]GETLOG runtime and extension implementation: get login username #70917

Uh oh!

Conversation

yiwu0b11 commented Nov 1, 2023 • edited by kiranchandramohan Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DavidTruby left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jeanPerier left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jeanPerier left a comment

Choose a reason for hiding this comment

Uh oh!

yiwu0b11 commented Nov 21, 2023

Uh oh!

klausler commented Nov 21, 2023

Uh oh!

Uh oh!

Uh oh!

yiwu0b11 commented Nov 27, 2023

Uh oh!

Uh oh!

Uh oh!

yiwu0b11 commented Dec 4, 2023

Uh oh!

klausler Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

yiwu0b11 Dec 6, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

yiwu0b11 commented Dec 6, 2023

Uh oh!

klausler commented Dec 6, 2023

Uh oh!

yiwu0b11 commented Dec 6, 2023

Uh oh!

Uh oh!

yiwu0b11 commented Nov 1, 2023 •

edited by kiranchandramohan

Loading

github-actions bot commented Nov 1, 2023 •

edited

Loading