Skip to content

[libc++][hardening] Clean up some legacy debug mode tests: #71016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@

// Make sure __debug_less asserts when the comparator is not consistent.

// REQUIRES: has-unix-headers
// UNSUPPORTED: !libcpp-has-legacy-debug-mode, c++03
// REQUIRES: has-unix-headers, libcpp-hardening-mode=debug
// UNSUPPORTED: c++03

#include <algorithm>
#include <iterator>
Expand Down
4 changes: 2 additions & 2 deletions libcxx/test/libcxx/algorithms/debug_less.pass.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@

// __debug_less checks that a comparator actually provides a strict-weak ordering.

// REQUIRES: has-unix-headers
// UNSUPPORTED: !libcpp-has-legacy-debug-mode, c++03
// REQUIRES: has-unix-headers, libcpp-hardening-mode=debug
// UNSUPPORTED: c++03

#include <algorithm>
#include <cassert>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@

// Make sure __debug_three_way_comp asserts when the comparator is not consistent.

// UNSUPPORTED: !libcpp-has-legacy-debug-mode, c++03, c++11, c++14, c++17
// REQUIRES: libcpp-hardening-mode=debug
// UNSUPPORTED: c++03, c++11, c++14, c++17

#include <algorithm>
#include <iterator>
Expand Down

This file was deleted.

52 changes: 0 additions & 52 deletions libcxx/test/libcxx/debug/extern-templates.sh.cpp

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
//
//===----------------------------------------------------------------------===//

// UNSUPPORTED: !libcpp-has-legacy-debug-mode, c++03, c++11, c++14
// REQUIRES: has-unix-headers
// UNSUPPORTED: c++03, c++11, c++14
// REQUIRES: has-unix-headers, libcpp-hardening-mode=debug

// <memory_resource>

Expand Down
1 change: 0 additions & 1 deletion libcxx/utils/data/ignore_format.txt
Original file line number Diff line number Diff line change
Expand Up @@ -708,7 +708,6 @@ libcxx/test/libcxx/containers/views/views.span/span.elem/assert.op_idx.pass.cpp
libcxx/test/libcxx/containers/views/views.span/span.sub/assert.first.pass.cpp
libcxx/test/libcxx/containers/views/views.span/span.sub/assert.last.pass.cpp
libcxx/test/libcxx/containers/views/views.span/span.sub/assert.subspan.pass.cpp
libcxx/test/libcxx/debug/containers/associative_containers.pass.cpp
libcxx/test/libcxx/debug/containers.multithread.pass.cpp
libcxx/test/libcxx/debug/containers/sequence_container_iterators.pass.cpp
libcxx/test/libcxx/debug/containers/string.pass.cpp
Expand Down
18 changes: 0 additions & 18 deletions libcxx/utils/libcxx/test/features.py
Original file line number Diff line number Diff line change
Expand Up @@ -136,24 +136,6 @@ def _getAndroidDeviceApi(cfg):
""",
),
),
# Some tests rely on creating shared libraries which link in the C++ Standard Library. In some
# cases, this doesn't work (e.g. if the library was built as a static archive and wasn't compiled
# as position independent). This feature informs the test suite of whether it's possible to create
# a shared library in a shell test by using the '-shared' compiler flag.
#
# Note: To implement this check properly, we need to make sure that we use something inside the
# compiled library, not only in the headers. It should be safe to assume that all implementations
# define `operator new` in the compiled library.
Feature(
name="cant-build-shared-library",
when=lambda cfg: not sourceBuilds(
cfg,
"""
void f() { new int(3); }
""",
["-shared"],
),
),
# Check for a Windows UCRT bug (fixed in UCRT/Windows 10.0.20348.0):
# https://developercommunity.visualstudio.com/t/utf-8-locales-break-ctype-functions-for-wchar-type/1653678
Feature(
Expand Down