Skip to content

[OpenMP][Flang] Fix some of the Fortan OpenMP Offloading tests #71070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

TIFitis
Copy link
Member

@TIFitis TIFitis commented Nov 2, 2023

target_map_common_block2.f90
- Fix the extra space in the print message.
- #67164 fixes this. So moving it outside of failing and also removing XFAIL marker.

basic-target-region-3D-array.f90
- Corrected the check to account for the new lines printed.

Depends on #67319

@llvmbot llvmbot added the openmp:libomptarget OpenMP offload runtime label Nov 2, 2023
Copy link
Contributor

@agozillon agozillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both test fixes LGTM.

target_map_common_block2.f90
	- Fix the extra space in the print message.
	- llvm#67164 fixes this. So moving it outside of failing and also removing XFAIL marker.

basic-target-region-3D-array.f90
	- Corrected the check to account for the new lines printed.

Depends on llvm#67319
@TIFitis
Copy link
Member Author

TIFitis commented Nov 6, 2023

Pushed commit be59fe5.

@TIFitis TIFitis closed this Nov 6, 2023
@TIFitis TIFitis deleted the omp_fortran_test branch November 6, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openmp:libomptarget OpenMP offload runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants