[libc++] <experimental/simd> Add implicit type conversion constructor for class simd/simd_mask #71132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
the
libc++
joy2myself
force-pushed
the
split_simd
branch
from
5e80afc to
101322c
Compare
|
Gentle ping. @philnik777 |
philnik777
approved these changes
Nov 14, 2023
| }; | ||
|
|
||
| template <class U, class T, class SimdAbi = ex::simd_abi::compatible<T>, class = void> | ||
| struct has_conversion_ctor : std::false_type {}; |
There was a problem hiding this comment.
I tried it but it seems is_convertible can not accurately test the type conversion constructor. When U is the same as T, simd[_mask]<U, Abi> is the same as simd[_mask]<T, Abi>. And the default copy constructor make them convertible no matter what the Abi is.
There was a problem hiding this comment.
Sorry, my previous understanding may not right. The new commit may be what you want.
joy2myself
force-pushed
the
split_simd
branch
from
101322c to
b601f16
Compare
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
joy2myself
force-pushed
the
split_simd
branch
from
b601f16 to
f5bf3ab
Compare
… for class simd/simd_mask
joy2myself
force-pushed
the
split_simd
branch
from
f5bf3ab to
acccf40
Compare
Guzhu-AMD
pushed a commit
to GPUOpen-Drivers/llvm-project
that referenced
this pull request
Nov 30, 2023
Local branch amd-gfx 461597c Merged main:0a9c6bea6b08 into amd-gfx:fad78e377956 Remote branch main ba89749 [libc++] <experimental/simd> Add implicit type conversion constructor for class simd/simd_mask (llvm#71132)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.