Skip to content

[NFC][RISCV] Add SiFive prefix for XSfvfnrclipxfqf description #71141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

sunshaoce
Copy link
Contributor

'XSfvfnrclipxfqf' (FP32-to-int8 Ranged Clip Instructions) -> 'XSfvfnrclipxfqf' (SiFive FP32-to-int8 Ranged Clip Instructions)

@llvmbot
Copy link
Member

llvmbot commented Nov 3, 2023

@llvm/pr-subscribers-backend-risc-v

Author: Shao-Ce SUN (sunshaoce)

Changes

'XSfvfnrclipxfqf' (FP32-to-int8 Ranged Clip Instructions) -> 'XSfvfnrclipxfqf' (SiFive FP32-to-int8 Ranged Clip Instructions)


Full diff: https://github.com/llvm/llvm-project/pull/71141.diff

1 Files Affected:

  • (modified) llvm/lib/Target/RISCV/RISCVFeatures.td (+2-2)
diff --git a/llvm/lib/Target/RISCV/RISCVFeatures.td b/llvm/lib/Target/RISCV/RISCVFeatures.td
index 1bcf190a583de18..f078ffd58e5e5e0 100644
--- a/llvm/lib/Target/RISCV/RISCVFeatures.td
+++ b/llvm/lib/Target/RISCV/RISCVFeatures.td
@@ -846,11 +846,11 @@ def HasVendorXSfvfwmaccqqq : Predicate<"Subtarget->hasVendorXSfvfwmaccqqq()">,
 
 def FeatureVendorXSfvfnrclipxfqf
     : SubtargetFeature<"xsfvfnrclipxfqf", "HasVendorXSfvfnrclipxfqf", "true",
-                       "'XSfvfnrclipxfqf' (FP32-to-int8 Ranged Clip Instructions)",
+                       "'XSfvfnrclipxfqf' (SiFive FP32-to-int8 Ranged Clip Instructions)",
                        [FeatureStdExtZve32f]>;
 def HasVendorXSfvfnrclipxfqf : Predicate<"Subtarget->hasVendorXSfvfnrclipxfqf()">,
                                AssemblerPredicate<(all_of FeatureVendorXSfvfnrclipxfqf),
-                               "'XSfvfnrclipxfqf' (FP32-to-int8 Ranged Clip Instructions)">;
+                               "'XSfvfnrclipxfqf' (SiFive FP32-to-int8 Ranged Clip Instructions)">;
 
 def FeatureVendorXCVbitmanip
     : SubtargetFeature<"xcvbitmanip", "HasVendorXCVbitmanip", "true",

Copy link
Collaborator

@topperc topperc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sunshaoce sunshaoce merged commit c14e086 into llvm:main Nov 3, 2023
@sunshaoce sunshaoce deleted the Xsfvfnrclipxfqf branch November 3, 2023 04:50
sunshaoce pushed a commit that referenced this pull request Nov 3, 2023
Guzhu-AMD pushed a commit to GPUOpen-Drivers/llvm-project that referenced this pull request Nov 9, 2023
Local branch amd-gfx 38e7e06 Merged main:8b36a19b3fe6 into amd-gfx:f05b7dadd0b5
Remote branch main c14e086 [NFC][RISCV] Add `SiFive` prefix for XSfvfnrclipxfqf description (llvm#71141)

Change-Id: Ia9ce29385a261da8979a13c5cf13fca3ab268dde
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants