Skip to content

[mlir][docs] Add link to Visual Studio Code extension #71190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

DavidSpickett
Copy link
Collaborator

The document talks a lot about it but never says explicitly that it comes from the marketplace. At first I thought I had to install it locally.

The document talks a lot about it but never says explicitly
that it comes from the marketplace. At first I thought I had
to install it locally.
@llvmbot
Copy link
Member

llvmbot commented Nov 3, 2023

@llvm/pr-subscribers-mlir

Author: David Spickett (DavidSpickett)

Changes

The document talks a lot about it but never says explicitly that it comes from the marketplace. At first I thought I had to install it locally.


Full diff: https://github.com/llvm/llvm-project/pull/71190.diff

1 Files Affected:

  • (modified) mlir/docs/Tools/MLIRLSP.md (+2-1)
diff --git a/mlir/docs/Tools/MLIRLSP.md b/mlir/docs/Tools/MLIRLSP.md
index b6c367f249b16ea..7a12b1d1aca22ef 100644
--- a/mlir/docs/Tools/MLIRLSP.md
+++ b/mlir/docs/Tools/MLIRLSP.md
@@ -392,7 +392,8 @@ to work:
 
 ### Visual Studio Code
 
-Provides language IDE features for [MLIR](https://mlir.llvm.org/) related
+The [MLIR extension](https://marketplace.visualstudio.com/items?itemName=llvm-vs-code-extensions.vscode-mlir)
+provides language IDE features for [MLIR](https://mlir.llvm.org/) related
 languages: [MLIR](#mlir---mlir-textual-assembly-format),
 [PDLL](#pdll---mlir-pdll-pattern-files), and [TableGen](#td---tablegen-files)
 

@DavidSpickett DavidSpickett merged commit a4fbe31 into llvm:main Nov 6, 2023
@DavidSpickett DavidSpickett deleted the mlir-ext-link branch November 6, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants