Skip to content

[lldb] Change Breakpoint::AddName return value #71236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 9, 2023
Merged

[lldb] Change Breakpoint::AddName return value #71236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1077476
[lldb] Change Breakpoint::AddName return value
bulbazord Nov 3, 2023
033b67a
Remove incorrect comments
bulbazord Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions lldb/include/lldb/Breakpoint/Breakpoint.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,9 +523,8 @@ class Breakpoint : public std::enable_shared_from_this<Breakpoint>,

lldb::SearchFilterSP GetSearchFilter() { return m_filter_sp; }

private: // The target needs to manage adding & removing names. It will do the
// checking for name validity as well.
bool AddName(llvm::StringRef new_name);
private:
void AddName(llvm::StringRef new_name);

void RemoveName(const char *name_to_remove) {
if (name_to_remove)
Expand Down
3 changes: 1 addition & 2 deletions lldb/source/Breakpoint/Breakpoint.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -841,9 +841,8 @@ bool Breakpoint::HasResolvedLocations() const {

size_t Breakpoint::GetNumLocations() const { return m_locations.GetSize(); }

bool Breakpoint::AddName(llvm::StringRef new_name) {
void Breakpoint::AddName(llvm::StringRef new_name) {
m_name_list.insert(new_name.str());
return true;
}

void Breakpoint::GetDescription(Stream *s, lldb::DescriptionLevel level,
Expand Down