Skip to content

[lldb][NFCI] Change parameter type in Target::AddNameToBreakpoint #71241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2023
Merged

[lldb][NFCI] Change parameter type in Target::AddNameToBreakpoint #71241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lldb/include/lldb/Target/Target.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -763,9 +763,10 @@ class Target : public std::enable_shared_from_this<Target>,
WatchpointList &GetWatchpointList() { return m_watchpoint_list; }

// Manages breakpoint names:
void AddNameToBreakpoint(BreakpointID &id, const char *name, Status &error);
void AddNameToBreakpoint(BreakpointID &id, llvm::StringRef name,
Status &error);

void AddNameToBreakpoint(lldb::BreakpointSP &bp_sp, const char *name,
void AddNameToBreakpoint(lldb::BreakpointSP &bp_sp, llvm::StringRef name,
Status &error);

void RemoveNameFromBreakpoint(lldb::BreakpointSP &bp_sp, ConstString name);
Expand Down
4 changes: 2 additions & 2 deletions lldb/source/Target/Target.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -727,7 +727,7 @@ void Target::AddBreakpoint(lldb::BreakpointSP bp_sp, bool internal) {
}
}

void Target::AddNameToBreakpoint(BreakpointID &id, const char *name,
void Target::AddNameToBreakpoint(BreakpointID &id, llvm::StringRef name,
Status &error) {
BreakpointSP bp_sp =
m_breakpoint_list.FindBreakpointByID(id.GetBreakpointID());
Expand All @@ -740,7 +740,7 @@ void Target::AddNameToBreakpoint(BreakpointID &id, const char *name,
AddNameToBreakpoint(bp_sp, name, error);
}

void Target::AddNameToBreakpoint(BreakpointSP &bp_sp, const char *name,
void Target::AddNameToBreakpoint(BreakpointSP &bp_sp, llvm::StringRef name,
Status &error) {
if (!bp_sp)
return;
Expand Down