Skip to content

[mlir] Fix handling of "no rank reduction" case in two Patterns #71293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2023
Merged

[mlir] Fix handling of "no rank reduction" case in two Patterns #71293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mlir/lib/Dialect/MemRef/IR/MemRefOps.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3099,7 +3099,7 @@ struct SubViewReturnTypeCanonicalizer {

// Directly return the non-rank reduced type if there are no dropped dims.
llvm::SmallBitVector droppedDims = op.getDroppedDims();
if (droppedDims.empty())
if (droppedDims.none())
return nonReducedType;

// Take the strides and offset from the non-rank reduced type.
Expand Down
2 changes: 1 addition & 1 deletion mlir/lib/Dialect/Tensor/Transforms/MergeConsecutiveInsertExtractSlicePatterns.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ struct DropRedundantInsertSliceRankExpansion
PatternRewriter &rewriter) const override {
// Nothing to do if no dims are dropped.
llvm::SmallBitVector droppedDims = extractSliceOp.getDroppedDims();
if (droppedDims.empty())
if (droppedDims.none())
return failure();

// Look for tensor.insert_slice op that has an inverse rank expansion.
Expand Down