[NFC][InstrProf]Refactor readPGOFuncNameStrings #71566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r each decoded string, and change it to a static function in cpp. Move its (sole) caller from header to cpp
david-xl
reviewed
Nov 7, 2023
|
|
||
| /// This interface is used by reader of CoverageMapping test | ||
| /// format. | ||
| inline Error create(StringRef D, uint64_t BaseAddr); |
There was a problem hiding this comment.
I think this is an artifact of 'diff' UI.
I swapped the order of two functions(
llvm-project/llvm/include/llvm/ProfileData/InstrProf.h
Lines 472 to 479 in fb8ff4c
create no longer has an 'inline' keyword (since its definition is moved to cpp files).
There was a problem hiding this comment.
ninja check-llvm pass (without compiler errors).
david-xl
approved these changes
Nov 9, 2023
zahiraam
pushed a commit
to zahiraam/llvm-project
that referenced
this pull request
Nov 20, 2023
Refactor this function to take a callback for each decoded string, rename it and change it to a static function in cpp. Move its (sole) caller definition from header to cpp. - This is a split of patch llvm#66825; to minimize the diff created in a big PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor this function to take a callback for each decoded string, and change it to a static function in cpp. Move its (sole) caller from header to cpp.