Skip to content

[BOLT] Move instrumentation option check (NFC) #71581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

yota9
Copy link
Member

@yota9 yota9 commented Nov 7, 2023

Move options check from emitBinary to more proper
adjustCommandLineOptions.

@yota9 yota9 added the BOLT label Nov 7, 2023
Copy link

github-actions bot commented Nov 7, 2023

✅ With the latest revision this PR passed the C/C++ code formatter.

Move options check from emitBinary to more proper
adjustCommandLineOptions.
Copy link
Contributor

@aaupov aaupov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The change makes sense, print the error early instead of during emission.

@yota9 yota9 merged commit 2e6f722 into llvm:main Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants