Skip to content

[lldb][AArch64][Linux] Add field information for the fpsr register #71651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,26 @@

using namespace lldb_private;

LinuxArm64RegisterFlags::Fields
LinuxArm64RegisterFlags::DetectFPSRFields(uint64_t hwcap, uint64_t hwcap2) {
// fpsr's contents are constant.
(void)hwcap;
(void)hwcap2;

return {
// Bits 31-28 are N/Z/C/V, only used by AArch32.
{"QC", 27},
// Bits 26-8 reserved.
{"IDC", 7},
// Bits 6-5 reserved.
{"IXC", 4},
{"UFC", 3},
{"OFC", 2},
{"DZC", 1},
{"IOC", 0},
};
}

LinuxArm64RegisterFlags::Fields
LinuxArm64RegisterFlags::DetectCPSRFields(uint64_t hwcap, uint64_t hwcap2) {
// The fields here are a combination of the Arm manual's SPSR_EL1,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ class LinuxArm64RegisterFlags {
using DetectorFn = std::function<Fields(uint64_t, uint64_t)>;

static Fields DetectCPSRFields(uint64_t hwcap, uint64_t hwcap2);
static Fields DetectFPSRFields(uint64_t hwcap, uint64_t hwcap2);

struct RegisterEntry {
RegisterEntry(llvm::StringRef name, unsigned size, DetectorFn detector)
Expand All @@ -65,8 +66,9 @@ class LinuxArm64RegisterFlags {
llvm::StringRef m_name;
RegisterFlags m_flags;
DetectorFn m_detector;
} m_registers[1] = {
} m_registers[2] = {
RegisterEntry("cpsr", 4, DetectCPSRFields),
RegisterEntry("fpsr", 4, DetectFPSRFields),
};

// Becomes true once field detection has been run for all registers.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -622,13 +622,14 @@ def test_info_register(self):
@skipUnlessPlatform(["linux"])
@skipIf(archs=no_match(["aarch64"]))
def test_register_read_fields(self):
"""Test that when debugging a live process, we see the fields of the
CPSR register."""
"""Test that when debugging a live process, we see the fields of certain
registers."""
self.build()
self.common_setup()

# N/Z/C/V bits will always be present, so check only for those.
self.expect("register read cpsr", substrs=["= (N = 0, Z = 1, C = 1, V = 0"])
self.expect("register read fpsr", substrs=["= (QC = 0, IDC = 0, IXC = 0"])

@skipUnlessPlatform(["linux"])
@skipIf(archs=no_match(["x86_64"]))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -577,6 +577,7 @@ def test_aarch64_sve_regs_full(self):
# Register field information should work with core files as it does a live process.
# The N/Z/C/V bits are always present so just check for those.
self.expect("register read cpsr", substrs=["= (N = 0, Z = 0, C = 0, V = 0"])
self.expect("register read fpsr", substrs=["= (QC = 0, IDC = 0, IXC = 0"])

@skipIfLLVMTargetMissing("AArch64")
def test_aarch64_pac_regs(self):
Expand Down