-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[flang] Fix missing CGPasses.h.inc #71691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@llvm/pr-subscribers-flang-driver Author: Julien Schueller (jschueller) ChangesCloses #61543 Full diff: https://github.com/llvm/llvm-project/pull/71691.diff 1 Files Affected:
diff --git a/flang/lib/Frontend/CMakeLists.txt b/flang/lib/Frontend/CMakeLists.txt
index a06b610112f2090..fb09a44100fabdf 100644
--- a/flang/lib/Frontend/CMakeLists.txt
+++ b/flang/lib/Frontend/CMakeLists.txt
@@ -15,6 +15,7 @@ add_flang_library(flangFrontend
DEPENDS
FIRDialect
+ FIROptCodeGenPassIncGen
FIROptTransformsPassIncGen
HLFIRDialect
MLIRIR
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks for this
Should be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
This has been approved by 2 reviewers - please just land it :) The change makes sense to me, but I've lost track of the dependencies between CMake targets. |
@jeanPerier could you merge it ? |
I am not here next week, so I would rather not merge a patch and not watch the build bots, but I am happy to merge it when I am back if no else does. |
I could reproduce using unix makefiles with -j1 option, with version 16.0.6
Closes #61543
Closes #57680