Skip to content

[flang] Fix missing CGPasses.h.inc #71691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2024
Merged

[flang] Fix missing CGPasses.h.inc #71691

merged 1 commit into from
Feb 19, 2024

Conversation

jschueller
Copy link
Contributor

@jschueller jschueller commented Nov 8, 2023

I could reproduce using unix makefiles with -j1 option, with version 16.0.6
Closes #61543
Closes #57680

@llvmbot llvmbot added flang:driver flang Flang issues not falling into any other category labels Nov 8, 2023
@llvmbot
Copy link
Member

llvmbot commented Nov 8, 2023

@llvm/pr-subscribers-flang-driver

Author: Julien Schueller (jschueller)

Changes

Closes #61543


Full diff: https://github.com/llvm/llvm-project/pull/71691.diff

1 Files Affected:

  • (modified) flang/lib/Frontend/CMakeLists.txt (+1)
diff --git a/flang/lib/Frontend/CMakeLists.txt b/flang/lib/Frontend/CMakeLists.txt
index a06b610112f2090..fb09a44100fabdf 100644
--- a/flang/lib/Frontend/CMakeLists.txt
+++ b/flang/lib/Frontend/CMakeLists.txt
@@ -15,6 +15,7 @@ add_flang_library(flangFrontend
 
   DEPENDS
   FIRDialect
+  FIROptCodeGenPassIncGen
   FIROptTransformsPassIncGen
   HLFIRDialect
   MLIRIR

@jschueller
Copy link
Contributor Author

Copy link
Contributor

@tblah tblah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for this

@ncihnegn
Copy link

Should be merged.

Copy link
Contributor

@jeanPerier jeanPerier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@jschueller
Copy link
Contributor Author

@banach-space
Copy link
Contributor

ping @schweitzpgi @banach-space @CarolineConcatto @jeanPerier

This has been approved by 2 reviewers - please just land it :)

The change makes sense to me, but I've lost track of the dependencies between CMake targets.

@jschueller
Copy link
Contributor Author

@jeanPerier could you merge it ?

@jeanPerier
Copy link
Contributor

@jeanPerier could you merge it ?

I am not here next week, so I would rather not merge a patch and not watch the build bots, but I am happy to merge it when I am back if no else does.

@tblah tblah merged commit da04f30 into llvm:main Feb 19, 2024
@jschueller jschueller deleted the patch-1 branch February 19, 2024 12:33
tblah pushed a commit that referenced this pull request Jul 29, 2024
Closes #84568

Similar to #71691 (reproduce with make -j1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flang:driver flang Flang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CGPasses.h.inc No such file (16.0.0 flang) CGPasses.h.inc No such file (15.0.0 flang)
6 participants