-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[AMDGPU] Revert "Preliminary patch for divergence driven instruction selection. Operands Folding 1." #71710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
[AMDGPU] Revert "Preliminary patch for divergence driven instruction selection. Operands Folding 1." #71710
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -165,9 +165,8 @@ define <2 x i16> @v_add_v2i16_neg_inline_imm_splat(<2 x i16> %a) { | |
; GFX7-LABEL: v_add_v2i16_neg_inline_imm_splat: | ||
; GFX7: ; %bb.0: | ||
; GFX7-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0) | ||
; GFX7-NEXT: s_movk_i32 s4, 0xffc0 | ||
; GFX7-NEXT: v_add_i32_e32 v0, vcc, s4, v0 | ||
; GFX7-NEXT: v_add_i32_e32 v1, vcc, s4, v1 | ||
; GFX7-NEXT: v_add_i32_e32 v0, vcc, 0xffffffc0, v0 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Folding improvements here. |
||
; GFX7-NEXT: v_add_i32_e32 v1, vcc, 0xffffffc0, v1 | ||
; GFX7-NEXT: s_setpc_b64 s[30:31] | ||
; | ||
; GFX9-LABEL: v_add_v2i16_neg_inline_imm_splat: | ||
|
@@ -180,10 +179,10 @@ define <2 x i16> @v_add_v2i16_neg_inline_imm_splat(<2 x i16> %a) { | |
; GFX8-LABEL: v_add_v2i16_neg_inline_imm_splat: | ||
; GFX8: ; %bb.0: | ||
; GFX8-NEXT: s_waitcnt vmcnt(0) expcnt(0) lgkmcnt(0) | ||
; GFX8-NEXT: v_mov_b32_e32 v2, 0xffffffc0 | ||
; GFX8-NEXT: v_add_u16_e32 v1, 0xffc0, v0 | ||
; GFX8-NEXT: v_add_u16_sdwa v0, v0, v2 dst_sel:WORD_1 dst_unused:UNUSED_PAD src0_sel:WORD_1 src1_sel:DWORD | ||
; GFX8-NEXT: v_or_b32_e32 v0, v1, v0 | ||
; GFX8-NEXT: v_mov_b32_e32 v1, 0xffffffc0 | ||
; GFX8-NEXT: v_add_u16_e32 v2, 0xffc0, v0 | ||
; GFX8-NEXT: v_add_u16_sdwa v0, v0, v1 dst_sel:WORD_1 dst_unused:UNUSED_PAD src0_sel:WORD_1 src1_sel:DWORD | ||
; GFX8-NEXT: v_or_b32_e32 v0, v2, v0 | ||
; GFX8-NEXT: s_setpc_b64 s[30:31] | ||
; | ||
; GFX10-LABEL: v_add_v2i16_neg_inline_imm_splat: | ||
|
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The motivation is to remove these recursive calls to
foldOperand
which are one cause of #71685.