Skip to content

[ADT][NFC] Remove Bitset comments copied from FeatureBitset #71778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

wangpc-pp
Copy link
Contributor

No description provided.

@wangpc-pp wangpc-pp requested a review from topperc November 9, 2023 06:39
@wangpc-pp wangpc-pp changed the title [ADT][NFC] Remove comments copied from FeatureBitset [ADT][NFC] Remove BitSet comments copied from FeatureBitset Nov 9, 2023
@llvmbot
Copy link
Member

llvmbot commented Nov 9, 2023

@llvm/pr-subscribers-llvm-adt

Author: Wang Pengcheng (wangpc-pp)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/71778.diff

1 Files Affected:

  • (modified) llvm/include/llvm/ADT/Bitset.h (-1)
diff --git a/llvm/include/llvm/ADT/Bitset.h b/llvm/include/llvm/ADT/Bitset.h
index 839d3fe3abf6e1a..4ba5c63535b2d2d 100644
--- a/llvm/include/llvm/ADT/Bitset.h
+++ b/llvm/include/llvm/ADT/Bitset.h
@@ -23,7 +23,6 @@
 
 namespace llvm {
 
-/// Container class for subtarget features.
 /// This is a constexpr reimplementation of a subset of std::bitset. It would be
 /// nice to use std::bitset directly, but it doesn't support constant
 /// initialization.

Copy link
Contributor

@kazutakahirata kazutakahirata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@wangpc-pp wangpc-pp changed the title [ADT][NFC] Remove BitSet comments copied from FeatureBitset [ADT][NFC] Remove Bitset comments copied from FeatureBitset Nov 9, 2023
@wangpc-pp wangpc-pp merged commit dfecfc7 into llvm:main Nov 9, 2023
@wangpc-pp wangpc-pp deleted the main-bitset-comment branch November 9, 2023 17:22
zahiraam pushed a commit to zahiraam/llvm-project that referenced this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants