Skip to content

Revert "[lldb] Read Checksum from DWARF line tables" #71864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

JDevlieghere
Copy link
Member

Reverts #71458 as it might have caused cross-project-test failures.

@JDevlieghere JDevlieghere merged commit 73519ba into main Nov 9, 2023
@JDevlieghere JDevlieghere deleted the revert-71458-ReadChecksumInSymbolFileDWARF branch November 9, 2023 20:43
@llvmbot llvmbot added the lldb label Nov 9, 2023
@llvmbot
Copy link
Member

llvmbot commented Nov 9, 2023

@llvm/pr-subscribers-lldb

Author: Jonas Devlieghere (JDevlieghere)

Changes

Reverts llvm/llvm-project#71458 as it might have caused cross-project-test failures.


Full diff: https://github.com/llvm/llvm-project/pull/71864.diff

1 Files Affected:

  • (modified) lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp (+1-8)
diff --git a/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp b/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
index 79d44bce3d663b6..aabd83a194932ff 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
+++ b/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
@@ -229,15 +229,8 @@ ParseSupportFilesFromPrologue(const lldb::ModuleSP &module,
         remapped_file = std::move(*file_path);
     }
 
-    Checksum checksum;
-    if (prologue.ContentTypes.HasMD5) {
-      const llvm::DWARFDebugLine::FileNameEntry &file_name_entry =
-          prologue.getFileNameEntry(idx);
-      checksum = file_name_entry.Checksum;
-    }
-
     // Unconditionally add an entry, so the indices match up.
-    support_files.EmplaceBack(remapped_file, style, checksum);
+    support_files.EmplaceBack(remapped_file, style);
   }
 
   return support_files;

zahiraam pushed a commit to zahiraam/llvm-project that referenced this pull request Nov 20, 2023
Reverts llvm#71458 as it might have caused
cross-project-test failures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants