Skip to content

[DebugInfo] Limit jump table test for x86 only #72082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Conversation

HaohaiWen
Copy link
Contributor

@HaohaiWen HaohaiWen commented Nov 13, 2023

32 bit target may generate different SelectionDAG for jump table.
Temporarily limit this test for 64bit x86 target only.

Other target may generate different SelectionDAG for jump table.
Temporarily limit this test for x86 only.
@llvmbot
Copy link
Member

llvmbot commented Nov 13, 2023

@llvm/pr-subscribers-debuginfo

Author: None (HaohaiWen)

Changes

Other target may generate different SelectionDAG for jump table.
Temporarily limit this test for x86 only.


Full diff: https://github.com/llvm/llvm-project/pull/72082.diff

1 Files Affected:

  • (modified) llvm/test/DebugInfo/Generic/debug-info-jump-table.ll (+1)
diff --git a/llvm/test/DebugInfo/Generic/debug-info-jump-table.ll b/llvm/test/DebugInfo/Generic/debug-info-jump-table.ll
index 202b688276287e2..5a4d11f00682f69 100644
--- a/llvm/test/DebugInfo/Generic/debug-info-jump-table.ll
+++ b/llvm/test/DebugInfo/Generic/debug-info-jump-table.ll
@@ -1,3 +1,4 @@
+; REQUIRES: x86-registered-target
 ; RUN: llc -debug-only=isel %s -o /dev/null 2>&1 | FileCheck --match-full-lines %s
 
 @str = private unnamed_addr constant [2 x i8] c"1\00", align 1

@HaohaiWen HaohaiWen merged commit 63e13f2 into llvm:main Nov 13, 2023
@HaohaiWen HaohaiWen deleted the testfix branch November 13, 2023 05:22
@nikic
Copy link
Contributor

nikic commented Nov 13, 2023

If this is limited to x86, shouldn't it be moved from the Generic to the X86 directory?

@HaohaiWen
Copy link
Contributor Author

If this is limited to x86, shouldn't it be moved from the Generic to the X86 directory?

My original intention is to test all targets. Looks like 32bit target has different DAG to check.
Do you know whether there's convenient way (no need to add -mtriple for each target in ;RUN) to test all 64bit target?

If not, I'll move it to X86 directory.

@nikic
Copy link
Contributor

nikic commented Nov 13, 2023

I'm not aware of a way to only test 64-bit targets. git grep "REQUIRES.*64" llvm didn't find anything promising either, so I suspect it doesn't exist right now.

zahiraam pushed a commit to zahiraam/llvm-project that referenced this pull request Nov 20, 2023
32 bit target may generate different SelectionDAG for jump table. 
Temporarily limit this test for 64bit X86 target only.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants