Skip to content

[GitHub] Remove pr-subscriber-wait.py download #72120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

DavidSpickett
Copy link
Collaborator

@DavidSpickett DavidSpickett commented Nov 13, 2023

This file and uses of it were removed in 64d5da6.

Uses of this file were removed in 64d5da6.
@llvmbot
Copy link
Member

llvmbot commented Nov 13, 2023

@llvm/pr-subscribers-github-workflow

Author: David Spickett (DavidSpickett)

Changes

Uses of this file were removed in 64d5da6.


Full diff: https://github.com/llvm/llvm-project/pull/72120.diff

1 Files Affected:

  • (modified) .github/workflows/pr-subscriber.yml (-1)
diff --git a/.github/workflows/pr-subscriber.yml b/.github/workflows/pr-subscriber.yml
index ef2ef7b9e4a35c1..03f60f619568f11 100644
--- a/.github/workflows/pr-subscriber.yml
+++ b/.github/workflows/pr-subscriber.yml
@@ -17,7 +17,6 @@ jobs:
         run: |
           curl -O -L https://raw.githubusercontent.com/"$GITHUB_REPOSITORY"/main/llvm/utils/git/github-automation.py
           curl -O -L https://raw.githubusercontent.com/"$GITHUB_REPOSITORY"/main/llvm/utils/git/requirements.txt
-          curl -O -L https://raw.githubusercontent.com/"$GITHUB_REPOSITORY"/main/.github/workflows/pr-subscriber-wait.py
           chmod a+x github-automation.py
           pip install -r requirements.txt
 

Copy link
Collaborator

@tstellar tstellar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the file still there too?

@DavidSpickett
Copy link
Collaborator Author

No it was removed also, I've clarified the PR description.

@boomanaiden154
Copy link
Contributor

boomanaiden154 commented Nov 13, 2023

After seeing this patch, I was wondering why the job didn't just outright fail. Apparently curl doesn't return a non-zero exit code for HTTP requests that return a code other than 200. Thanks for the cleanup!

@DavidSpickett DavidSpickett merged commit 9cb1673 into llvm:main Nov 14, 2023
@DavidSpickett DavidSpickett deleted the remove-waitpy branch November 14, 2023 08:21
@DavidSpickett
Copy link
Collaborator Author

Apparently curl doesn't return a non-zero exit code for HTTP requests that return a code other than 200.

If you happen to know the option to make curl fail earlier that would be a good change to make.

@tru
Copy link
Collaborator

tru commented Nov 14, 2023

--fail is the right one I think.

@DavidSpickett
Copy link
Collaborator Author

If you happen to know the option to make curl fail earlier that would be a good change to make.

#72238

zahiraam pushed a commit to zahiraam/llvm-project that referenced this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants