-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[GitHub] Remove pr-subscriber-wait.py download #72120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Uses of this file were removed in 64d5da6.
@llvm/pr-subscribers-github-workflow Author: David Spickett (DavidSpickett) ChangesUses of this file were removed in 64d5da6. Full diff: https://github.com/llvm/llvm-project/pull/72120.diff 1 Files Affected:
diff --git a/.github/workflows/pr-subscriber.yml b/.github/workflows/pr-subscriber.yml
index ef2ef7b9e4a35c1..03f60f619568f11 100644
--- a/.github/workflows/pr-subscriber.yml
+++ b/.github/workflows/pr-subscriber.yml
@@ -17,7 +17,6 @@ jobs:
run: |
curl -O -L https://raw.githubusercontent.com/"$GITHUB_REPOSITORY"/main/llvm/utils/git/github-automation.py
curl -O -L https://raw.githubusercontent.com/"$GITHUB_REPOSITORY"/main/llvm/utils/git/requirements.txt
- curl -O -L https://raw.githubusercontent.com/"$GITHUB_REPOSITORY"/main/.github/workflows/pr-subscriber-wait.py
chmod a+x github-automation.py
pip install -r requirements.txt
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the file still there too?
No it was removed also, I've clarified the PR description. |
After seeing this patch, I was wondering why the job didn't just outright fail. Apparently curl doesn't return a non-zero exit code for HTTP requests that return a code other than 200. Thanks for the cleanup! |
If you happen to know the option to make curl fail earlier that would be a good change to make. |
|
|
This file and uses of it were removed in 64d5da6.
This file and uses of it were removed in 64d5da6.