Skip to content

[PowerPC][EarlyIfConversion] Do not insert isel if subtarget doesn't support isel #72211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

bzEq
Copy link
Collaborator

@bzEq bzEq commented Nov 14, 2023

Some subtargets of PPC don't support isel instruction, early-ifcvt should not insert this instruction.

Copy link
Collaborator

@chenzheng1030 chenzheng1030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.
Please wait for some days in case other reviewers have comments.

@bzEq bzEq merged commit eb76982 into llvm:main Nov 20, 2023
sr-tream pushed a commit to sr-tream/llvm-project that referenced this pull request Nov 20, 2023
…t support `isel` (llvm#72211)

Some subtargets of PPC don't support `isel` instruction, early-ifcvt
should not insert this instruction.
zahiraam pushed a commit to zahiraam/llvm-project that referenced this pull request Nov 20, 2023
…t support `isel` (llvm#72211)

Some subtargets of PPC don't support `isel` instruction, early-ifcvt
should not insert this instruction.
@nemanjai
Copy link
Member

What problem is this solving? PPCExpandISEL should be getting rid of these on targets that don't support them.
I am not against this patch, but there may be other sources of isel instructions and if this pass isn't cleaning them up, it may be an indication that something is wrong with that pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants