Skip to content

[OpenMP] Mute OpenMP Target Enter, Exit and Data codegen for device pass #72287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

TIFitis
Copy link
Member

@TIFitis TIFitis commented Nov 14, 2023

No description provided.

@TIFitis TIFitis requested a review from agozillon November 14, 2023 17:03
@llvmbot llvmbot added flang:openmp clang:openmp OpenMP related changes to Clang labels Nov 14, 2023
@llvmbot
Copy link
Member

llvmbot commented Nov 14, 2023

@llvm/pr-subscribers-flang-openmp

Author: Akash Banerjee (TIFitis)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/72287.diff

1 Files Affected:

  • (modified) llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp (+4)
diff --git a/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp b/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
index 24d15267a65e933..4e25d57a06a4f81 100644
--- a/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
+++ b/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
@@ -4566,6 +4566,10 @@ OpenMPIRBuilder::InsertPointTy OpenMPIRBuilder::createTargetData(
   if (!updateToLocation(Loc))
     return InsertPointTy();
 
+  // Disable TargetData CodeGen on Device pass.
+  if (Config.isTargetDevice())
+    return Builder.saveIP();
+
   Builder.restoreIP(CodeGenIP);
   bool IsStandAlone = !BodyGenCB;
   MapInfosTy *MapInfo;

@TIFitis TIFitis requested a review from jsjodin November 14, 2023 17:09
Copy link
Contributor

@agozillon agozillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Akash, it LGTM. Might be worth a second opinion from @jsjodin

@TIFitis TIFitis force-pushed the targetdata-devicepass branch from 10f3f3b to 4f1fc8c Compare November 14, 2023 17:34
@TIFitis TIFitis merged commit 767b342 into llvm:main Nov 15, 2023
@TIFitis TIFitis deleted the targetdata-devicepass branch November 15, 2023 13:05
zahiraam pushed a commit to zahiraam/llvm-project that referenced this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:openmp OpenMP related changes to Clang flang:openmp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants