[Kaleidoscope] Switch to the new PassManager, revisited. #72324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeubanks
approved these changes
Nov 16, 2023
sr-tream
pushed a commit
to sr-tream/llvm-project
that referenced
this pull request
Nov 20, 2023
Rollforward of llvm#69032, which was reverted in [63d19cf](llvm@63d19cf). New: implemented changes in llvm#69032 (comment). Given the PassBuilder is how we expect users to register passes, the tutorial should reflect that.
zahiraam
pushed a commit
to zahiraam/llvm-project
that referenced
this pull request
Nov 20, 2023
Rollforward of llvm#69032, which was reverted in [63d19cf](llvm@63d19cf). New: implemented changes in llvm#69032 (comment). Given the PassBuilder is how we expect users to register passes, the tutorial should reflect that.
nikic
pushed a commit
that referenced
this pull request
Dec 12, 2024
Kaleidoscope has switched to new pass manager before (#72324), but both code and tutorial document have some missing parts. This pull request fixes the following problems: 1. Adds `PromotePass` to the function pass manager. This pass was removed during the switch from legacy pass manager to the new pass manager. 2. Syncs the tutorial with the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollforward of #69032, which was reverted in 63d19cf.
New: implemented changes in #69032 (comment).
Given the PassBuilder is how we expect users to register passes, the tutorial should reflect that.