Skip to content

[NFC] Remove outdated comment #72591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Conversation

AdvenamTacet
Copy link
Member

Special-casing has been already removed.

Special-casing has been already removed.
@AdvenamTacet AdvenamTacet requested a review from ldionne November 17, 2023 01:15
@AdvenamTacet AdvenamTacet self-assigned this Nov 17, 2023
@AdvenamTacet AdvenamTacet requested a review from a team as a code owner November 17, 2023 01:15
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Nov 17, 2023
@llvmbot
Copy link
Member

llvmbot commented Nov 17, 2023

@llvm/pr-subscribers-libcxx

Author: Tacet (AdvenamTacet)

Changes

Special-casing has been already removed.


Full diff: https://github.com/llvm/llvm-project/pull/72591.diff

1 Files Affected:

  • (modified) libcxx/include/deque (-1)
diff --git a/libcxx/include/deque b/libcxx/include/deque
index d2ddce319567166..1438f1e992e203f 100644
--- a/libcxx/include/deque
+++ b/libcxx/include/deque
@@ -967,7 +967,6 @@ public:
 // For more details, see the "Using libc++" documentation page or
 // the documentation for __sanitizer_annotate_contiguous_container.
 #if !defined(_LIBCPP_HAS_NO_ASAN)
-    // TODO LLVM18: Remove the special-casing
     _LIBCPP_HIDE_FROM_ABI void __annotate_double_ended_contiguous_container(
         const void* __beg,
         const void* __end,

@ldionne ldionne merged commit 00da5eb into llvm:main Nov 17, 2023
sr-tream pushed a commit to sr-tream/llvm-project that referenced this pull request Nov 20, 2023
Special-casing has been already removed.
zahiraam pushed a commit to zahiraam/llvm-project that referenced this pull request Nov 20, 2023
Special-casing has been already removed.
@AdvenamTacet AdvenamTacet deleted the nfc-remove-a-comment branch January 22, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants