Skip to content

[Github] Build clang docs in CI if autogenerated files change #72623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

boomanaiden154
Copy link
Contributor

These are unlikely to produce errors in the build, assuming that the tablegen emitter works as expected, but we're still losing some documentation build testing coverage but not building upon changes to these files.

These are unlikely to produce errors in the build, assuming that the
tablegen emitter works as expected, but we're still losing some
documentation build testing coverage but not building upon changes to
these files.
@llvmbot
Copy link
Member

llvmbot commented Nov 17, 2023

@llvm/pr-subscribers-github-workflow

Author: Aiden Grossman (boomanaiden154)

Changes

These are unlikely to produce errors in the build, assuming that the tablegen emitter works as expected, but we're still losing some documentation build testing coverage but not building upon changes to these files.


Full diff: https://github.com/llvm/llvm-project/pull/72623.diff

1 Files Affected:

  • (modified) .github/workflows/docs.yml (+9)
diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
index 6329d777a182031..ae68dfd3a4d12e0 100644
--- a/.github/workflows/docs.yml
+++ b/.github/workflows/docs.yml
@@ -15,6 +15,9 @@ on:
     paths:
       - 'llvm/docs/**'
       - 'clang/docs/**'
+      - 'clang/include/clang/Basic/AttrDocs.td'
+      - 'clang/include/clang/Driver/ClangOptionDocs.td'
+      - 'clang/include/clang/Basic/DiagnosticDocs.td'
       - 'clang-tools-extra/docs/**'
       - 'lldb/docs/**'
       - 'libunwind/docs/**'
@@ -28,6 +31,9 @@ on:
     paths:
       - 'llvm/docs/**'
       - 'clang/docs/**'
+      - 'clang/include/clang/Basic/AttrDocs.td'
+      - 'clang/include/clang/Driver/ClangOptionDocs.td'
+      - 'clang/include/clang/Basic/DiagnosticDocs.td'
       - 'clang-tools-extra/docs/**'
       - 'lldb/docs/**'
       - 'libunwind/docs/**'
@@ -62,6 +68,9 @@ jobs:
               - 'llvm/docs/**'
             clang:
               - 'clang/docs/**'
+              - 'clang/include/clang/Basic/AttrDocs.td'
+              - 'clang/include/clang/Driver/ClangOptionDocs.td'
+              - 'clang/include/clang/Basic/DiagnosticDocs.td'
             clang-tools-extra:
               - 'clang-tools-extra/docs/**'
             lldb:

@boomanaiden154
Copy link
Contributor Author

Still need to try and find a more scalable solution than copying and pasting the paths into three separate parts of the document. Will look into that in a bit.

@tstellar
Copy link
Collaborator

Still need to try and find a more scalable solution than copying and pasting the paths into three separate parts of the document. Will look into that in a bit.

I think you have to abandon the builtin github path filtering if you only want to maintain the list in one place. Creating a separate workflow file for each documentation build would get you from 3 copies of the list to 2, but I'm not sure that's really that much better.

@boomanaiden154 boomanaiden154 merged commit 17fcad7 into llvm:main Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants