Skip to content

[libc++] Fix char_traits deprecation message (LLVM 18 -> 19) #72690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ldionne
Copy link
Member

@ldionne ldionne commented Nov 17, 2023

We intend to remove the base specialization in LLVM 19, not LLVM 18. We simply forgot to update the deprecation message accordingly.

We intend to remove the base specialization in LLVM 19, not LLVM 18.
We simply forgot to update the deprecation message accordingly.
@ldionne ldionne requested a review from a team as a code owner November 17, 2023 19:10
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Nov 17, 2023
@llvmbot
Copy link
Member

llvmbot commented Nov 17, 2023

@llvm/pr-subscribers-libcxx

Author: Louis Dionne (ldionne)

Changes

We intend to remove the base specialization in LLVM 19, not LLVM 18. We simply forgot to update the deprecation message accordingly.


Full diff: https://github.com/llvm/llvm-project/pull/72690.diff

1 Files Affected:

  • (modified) libcxx/include/__string/char_traits.h (+1-1)
diff --git a/libcxx/include/__string/char_traits.h b/libcxx/include/__string/char_traits.h
index ca9867c39067d5d..005df9a98f17a28 100644
--- a/libcxx/include/__string/char_traits.h
+++ b/libcxx/include/__string/char_traits.h
@@ -77,7 +77,7 @@ exposition-only to document what members a char_traits specialization should pro
 //
 #if !defined(_LIBCPP_CHAR_TRAITS_REMOVE_BASE_SPECIALIZATION)
 template <class _CharT>
-struct _LIBCPP_DEPRECATED_("char_traits<T> for T not equal to char, wchar_t, char8_t, char16_t or char32_t is non-standard and is provided for a temporary period. It will be removed in LLVM 18, so please migrate off of it.")
+struct _LIBCPP_DEPRECATED_("char_traits<T> for T not equal to char, wchar_t, char8_t, char16_t or char32_t is non-standard and is provided for a temporary period. It will be removed in LLVM 19, so please migrate off of it.")
     char_traits
 {
     using char_type  = _CharT;

@ldionne ldionne merged commit a1ae7e9 into llvm:main Nov 17, 2023
sr-tream pushed a commit to sr-tream/llvm-project that referenced this pull request Nov 20, 2023
)

We intend to remove the base specialization in LLVM 19, not LLVM 18. We
simply forgot to update the deprecation message accordingly.
zahiraam pushed a commit to zahiraam/llvm-project that referenced this pull request Nov 20, 2023
)

We intend to remove the base specialization in LLVM 19, not LLVM 18. We
simply forgot to update the deprecation message accordingly.
@ldionne ldionne deleted the review/fix-char-traits-deprecation-message branch November 20, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants