Skip to content

[libc++] Don't open-close namespace std in __config #72695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

ldionne
Copy link
Member

@ldionne ldionne commented Nov 17, 2023

This doesn't seem necessary and it is just kind of weird to do that in __config, so remove it.

This doesn't seem necessary and it is just kind of weird to do that
in __config, so remove it.
@ldionne ldionne requested a review from philnik777 November 17, 2023 19:55
@ldionne ldionne requested a review from a team as a code owner November 17, 2023 19:55
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Nov 17, 2023
@llvmbot
Copy link
Member

llvmbot commented Nov 17, 2023

@llvm/pr-subscribers-libcxx

Author: Louis Dionne (ldionne)

Changes

This doesn't seem necessary and it is just kind of weird to do that in __config, so remove it.


Full diff: https://github.com/llvm/llvm-project/pull/72695.diff

1 Files Affected:

  • (modified) libcxx/include/__config (-2)
diff --git a/libcxx/include/__config b/libcxx/include/__config
index e8da358bb8d7cd5..90e23dbdd8622b5 100644
--- a/libcxx/include/__config
+++ b/libcxx/include/__config
@@ -836,8 +836,6 @@ typedef __char32_t char32_t;
 #  define _LIBCPP_END_NAMESPACE_STD }}
 #  define _VSTD std
 
-_LIBCPP_BEGIN_NAMESPACE_STD _LIBCPP_END_NAMESPACE_STD
-
 #  if _LIBCPP_STD_VER >= 17
 #    define _LIBCPP_BEGIN_NAMESPACE_FILESYSTEM                                                                         \
        _LIBCPP_BEGIN_NAMESPACE_STD inline namespace __fs { namespace filesystem {

@ldionne ldionne merged commit 9824040 into llvm:main Nov 20, 2023
@ldionne ldionne deleted the review/remote-namespace-from-config branch November 20, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants