[libc++] Stop checking for trailing whitespace in check-generated-output

[ldionne]

Trailing whitespace is removed by clang-format, so if someone tries to check-in new code with trailing whitespaces, it'll be caught by the clang-format job. Removing this duplication helps reduce the confusion around our numerous ways of enforcing formatting rules.

[llvmbot]

@llvm/pr-subscribers-libcxx

Author: Louis Dionne (ldionne)

Changes

Trailing whitespace is removed by clang-format, so if someone tries to check-in new code with trailing whitespaces, it'll be caught by the clang-format job. Removing this duplication helps reduce the confusion around our numerous ways of enforcing formatting rules.

---

Full diff: https://github.com/llvm/llvm-project/pull/72711.diff

1 Files Affected:

• (modified) libcxx/utils/ci/run-buildbot (-3)

diff --git a/libcxx/utils/ci/run-buildbot b/libcxx/utils/ci/run-buildbot
index fe99388a799be8a..65d0cd6ee6b2871 100755
--- a/libcxx/utils/ci/run-buildbot
+++ b/libcxx/utils/ci/run-buildbot
@@ -262,9 +262,6 @@ check-generated-output)
            --exclude 'transcoding.pass.cpp' \
            --exclude 'underflow.pass.cpp' \
            || false
-
-    # Reject code with trailing whitespace
-    ! grep -rn '[[:blank:]]$' libcxx/include libcxx/src libcxx/test libcxx/benchmarks || false
 ;;
 #
 # Various Standard modes

[philnik777]

This will only catch trailing whitespaces in files where we check clang-format though. Or do we clang-format everything now?

[ldionne]

This will only catch trailing whitespaces in files where we check clang-format though. Or do we clang-format everything now?

We clang-format pretty much everything -- all the source code except the stuff in ignore_format.txt. I think in practice this is sufficient.