Skip to content

[Github] Add build Flang docs in CI if autogenerated files change #72721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

boomanaiden154
Copy link
Contributor

Currently, when changes are made to the tablegen files that build the docs, the docs build is not tested. This should rarely cause breakages, but it's cheap to test and there isn't a major reason not to.

Currently, when changes are made to the tablegen files that build the
docs, the docs build is not tested. This should rarely cause breakages,
but it's cheap to test and there isn't a major reason not to.
@llvmbot
Copy link
Member

llvmbot commented Nov 18, 2023

@llvm/pr-subscribers-github-workflow

Author: Aiden Grossman (boomanaiden154)

Changes

Currently, when changes are made to the tablegen files that build the docs, the docs build is not tested. This should rarely cause breakages, but it's cheap to test and there isn't a major reason not to.


Full diff: https://github.com/llvm/llvm-project/pull/72721.diff

1 Files Affected:

  • (modified) .github/workflows/docs.yml (+3)
diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
index 6329d777a182031..d872097b239d27e 100644
--- a/.github/workflows/docs.yml
+++ b/.github/workflows/docs.yml
@@ -24,6 +24,7 @@ on:
       - 'openmp/docs/**'
       - 'polly/docs/**'
       - 'flang/docs/**'
+      - 'flang/include/flang/Optimizer/Dialect/FIROps.td'
   pull_request:
     paths:
       - 'llvm/docs/**'
@@ -37,6 +38,7 @@ on:
       - 'openmp/docs/**'
       - 'polly/docs/**'
       - 'flang/docs/**'
+      - 'flang/include/flang/Optimizer/Dialect/FIROps.td'
 
 jobs:
   check-docs-build:
@@ -80,6 +82,7 @@ jobs:
               - 'polly/docs/**'
             flang:
               - 'flang/docs/**'
+              - 'flang/include/flang/Optimizer/Dialect/FIROps.td'
       - name: Fetch LLVM sources (PR)
         if: ${{ github.event_name == 'pull_request' }}
         uses: actions/checkout@v4

Copy link
Contributor

@kiranchandramohan kiranchandramohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. We probably have to add the HLFIR dialect ops as well. But that can come in a separate patch since it is not yet added to the documentation.

@boomanaiden154 boomanaiden154 merged commit 48c5c1b into llvm:main Nov 18, 2023
sr-tream pushed a commit to sr-tream/llvm-project that referenced this pull request Nov 20, 2023
…vm#72721)

Currently, when changes are made to the tablegen files that build the
docs, the docs build is not tested. This should rarely cause breakages,
but it's cheap to test and there isn't a major reason not to.
zahiraam pushed a commit to zahiraam/llvm-project that referenced this pull request Nov 20, 2023
…vm#72721)

Currently, when changes are made to the tablegen files that build the
docs, the docs build is not tested. This should rarely cause breakages,
but it's cheap to test and there isn't a major reason not to.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants