-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[clang] Fix lit test failure caused by https://github.com/llvm/llvm-project/pull/70762 #72928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@llvm/pr-subscribers-clang Author: None (smanna12) ChangesFull diff: https://github.com/llvm/llvm-project/pull/72928.diff 1 Files Affected:
diff --git a/clang/test/Sema/code_align.c b/clang/test/Sema/code_align.c
index 539c0c0b0f1ccfb..003bc08b87482c9 100644
--- a/clang/test/Sema/code_align.c
+++ b/clang/test/Sema/code_align.c
@@ -75,7 +75,7 @@ void foo1(int A)
[[clang::code_align(9223372036854775808)]]
for(int I=0; I<256; ++I) { bar(I); }
- // expected-error@+1{{'code_align' attribute requires an integer argument which is a constant power of two between 1 and 4096 inclusive; provided argument was (__int128_t)1311768467294899680ULL << 64}}
+ // cpp-local-error@+1{{'code_align' attribute requires an integer argument which is a constant power of two between 1 and 4096 inclusive; provided argument was (__int128_t)1311768467294899680ULL << 64}}
[[clang::code_align((__int128_t)0x1234567890abcde0ULL << 64)]]
for(int I=0; I<256; ++I) { bar(I); }
@@ -85,7 +85,6 @@ void foo1(int A)
// cpp-local-error@+3{{expression is not an integral constant expression}}
// cpp-local-note@+2{{left shift of negative value -1311768467294899680}}
- // c-local-error@+1{{'code_align' attribute requires an integer argument which is a constant power of two between 1 and 4096 inclusive; provided argument was -(__int128_t)1311768467294899680ULL << 64}}
[[clang::code_align(-(__int128_t)0x1234567890abcde0ULL << 64)]]
for(int I=0; I<256; ++I) { bar(I); }
@@ -127,7 +126,7 @@ void code_align_dependent() {
[[clang::code_align(A)]] // OK
for(int I=0; I<128; ++I) { bar(I); }
- [[clang::code_align(A)]] // expected-note{{previous attribute is here}}
+ [[clang::code_align(A)]] // cpp-local-note{{previous attribute is here}}
[[clang::code_align(E)]] // cpp-local-error{{conflicting loop attribute 'code_align'}}
for(int I=0; I<128; ++I) { bar(I); }
@@ -143,7 +142,7 @@ void code_align_dependent() {
template<int ITMPL>
void bar3() {
- [[clang::code_align(8)]] // expected-note{{previous attribute is here}}
+ [[clang::code_align(8)]] // cpp-local-note{{previous attribute is here}}
[[clang::code_align(ITMPL)]] // cpp-local-error{{conflicting loop attribute 'code_align'}} \
// cpp-local-note@#temp-instantiation{{in instantiation of function template specialization 'bar3<4>' requested here}}
for(int I=0; I<128; ++I) { bar(I); }
@@ -151,7 +150,7 @@ void bar3() {
template<int ITMPL1>
void bar4() {
- [[clang::code_align(ITMPL1)]] // expected-note{{previous attribute is here}}
+ [[clang::code_align(ITMPL1)]] // cpp-local-note{{previous attribute is here}}
[[clang::code_align(32)]] // cpp-local-error{{conflicting loop attribute 'code_align'}} \
// cpp-local-note@#temp-instantiation1{{in instantiation of function template specialization 'bar4<64>' requested here}}
for(int I=0; I<128; ++I) { bar(I); }
|
Buildbot is showing the failures below:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lit test generates different outputs for usage of __int128_t in clang-armv8-quick environment. This patch adds triple to fix the lit failure.