Skip to content

[BOLT] [Profile] Fix type mismatch error #73016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

gz83
Copy link
Contributor

@gz83 gz83 commented Nov 21, 2023

issue: #73006

@maksfb

@maksfb maksfb added the BOLT label Nov 21, 2023
@gz83 gz83 force-pushed the type-mismatch-error branch from 4fe93d7 to 74ce118 Compare November 22, 2023 02:39
@gz83
Copy link
Contributor Author

gz83 commented Nov 22, 2023

I have modified the code as per your instructions, please review again, thank you!

@maksfb

@gz83 gz83 requested a review from maksfb November 22, 2023 02:49
Copy link
Contributor

@maksfb maksfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please add "Fix build issue on Windows" to the commit summary. Thanks for reporting and the fix.

Fix build issue on Windows.

issue:llvm#73006
@gz83 gz83 force-pushed the type-mismatch-error branch from 74ce118 to bce8d2e Compare November 22, 2023 03:04
@gz83
Copy link
Contributor Author

gz83 commented Nov 22, 2023

LGTM. Please add "Fix build issue on Windows" to the commit summary. Thanks for reporting and the fix.

Done.

If there are no other problems, please help me merge it, thank you!

@maksfb

@gz83
Copy link
Contributor Author

gz83 commented Nov 22, 2023

3 checks passed

@maksfb maksfb merged commit 3af586f into llvm:main Nov 22, 2023
@gz83 gz83 deleted the type-mismatch-error branch November 22, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants