Skip to content

[libcxx] Reformat libcxx/include/__config #73137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

hawkinsw
Copy link
Contributor

Satisfy the never happy clang-format.

Satisfy the never happy clang-format.
@hawkinsw hawkinsw requested a review from a team as a code owner November 22, 2023 15:20
@hawkinsw hawkinsw self-assigned this Nov 22, 2023
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Nov 22, 2023
@llvmbot
Copy link
Member

llvmbot commented Nov 22, 2023

@llvm/pr-subscribers-libcxx

Author: Will Hawkins (hawkinsw)

Changes

Satisfy the never happy clang-format.


Full diff: https://github.com/llvm/llvm-project/pull/73137.diff

1 Files Affected:

  • (modified) libcxx/include/__config (+1-1)
diff --git a/libcxx/include/__config b/libcxx/include/__config
index e8da358bb8d7cd5..d16cc88b1abb813 100644
--- a/libcxx/include/__config
+++ b/libcxx/include/__config
@@ -806,7 +806,7 @@ typedef __char32_t char32_t;
 #  ifndef _LIBCPP_NO_ABI_TAG
 #    define _LIBCPP_HIDE_FROM_ABI                                                                                      \
       _LIBCPP_HIDDEN _LIBCPP_EXCLUDE_FROM_EXPLICIT_INSTANTIATION                                                       \
-          __attribute__((__abi_tag__(_LIBCPP_TOSTRING(_LIBCPP_ODR_SIGNATURE))))
+      __attribute__((__abi_tag__(_LIBCPP_TOSTRING(_LIBCPP_ODR_SIGNATURE))))
 #  else
 #    define _LIBCPP_HIDE_FROM_ABI _LIBCPP_HIDDEN _LIBCPP_EXCLUDE_FROM_EXPLICIT_INSTANTIATION
 #  endif

@ldionne
Copy link
Member

ldionne commented Nov 22, 2023

I think the generated-files CI job issue is something else, since that job still seems to still be failing after your patch. That's why I am trying to nuke it here: #73135

I suspect you are using a slightly different version of clang-format than what the upstream CI clang-format job is using, since that one seems to be happy with __config even before your change (and surprisingly, after your change too).

@ldionne
Copy link
Member

ldionne commented Nov 23, 2023

I think this is not an issue anymore since we removed the part of generated-files that checked the ignore_format.txt list.

@ldionne ldionne closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants