Skip to content

[code-format] Also include libc++ extensionless headers #73142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 22, 2023
Merged

[code-format] Also include libc++ extensionless headers #73142

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60b6c04
[code-format] Also include libc++ extensionless headers
ldionne Nov 22, 2023
0235e24
Darker
ldionne Nov 22, 2023
074a0e8
Also include .cppm and .inc files.
ldionne Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion llvm/utils/git/code-format-helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,13 +126,18 @@ def should_be_excluded(self, path: str) -> bool:
return True
return False

def should_include_extensionless_file(self, path: str) -> bool:
return path.startswith("libcxx/include")

def filter_changed_files(self, changed_files: list[str]) -> list[str]:
filtered_files = []
for path in changed_files:
_, ext = os.path.splitext(path)
if ext in (".cpp", ".c", ".h", ".hpp", ".hxx", ".cxx"):
if ext in (".cpp", ".c", ".h", ".hpp", ".hxx", ".cxx", ".inc", ".cppm"):
if not self.should_be_excluded(path):
filtered_files.append(path)
elif ext == "" and self.should_include_extensionless_file(path):
filtered_files.append(path)
return filtered_files

def format_run(
Expand Down