[flang] Make .exe extension of the linker optional (NFC)

[kkwli]

The change in 34e4e5eb70818 breaks our local build that uses -DCLANG_DEFAULT_LINKER=lld. Although there is an open issue (#73153) related to CLANG_DEFAULT_LINKER and FLANG_DEFAULT_LINKER, the name of the linker may not have the .exe extension.

[llvmbot]

@llvm/pr-subscribers-flang-driver

Author: None (kkwli)

Changes

The change in 34e4e5eb70818 breaks our local build that uses -DCLANG_DEFAULT_LINKER=lld. Although there is an open issue (#73153) related to CLANG_DEFAULT_LINKER and FLANG_DEFAULT_LINKER, the name of the linker may not have the .exe extension.

---

Full diff: https://github.com/llvm/llvm-project/pull/73157.diff

1 Files Affected:

• (modified) flang/test/Driver/dynamic-linker.f90 (+1-1)

diff --git a/flang/test/Driver/dynamic-linker.f90 b/flang/test/Driver/dynamic-linker.f90
index 2745822dc107769..df119c22a2ea516 100644
--- a/flang/test/Driver/dynamic-linker.f90
+++ b/flang/test/Driver/dynamic-linker.f90
@@ -15,6 +15,6 @@
 ! GNU-LINKER-OPTIONS-SAME: "-rpath" "/path/to/dir"
 
 ! For MSVC, adding -static does not add any additional linker options.
-! MSVC-LINKER-OPTIONS: "{{.*}}link.exe"
+! MSVC-LINKER-OPTIONS: "{{.*}}link{{(.exe)?}}"
 ! MSVC-LINKER-OPTIONS-SAME: "-dll"
 ! MSVC-LINKER-OPTIONS-SAME: "-rpath" "/path/to/dir"

[tarunprabhu]

LGTM.

[banach-space]

Looking at

llvm-project/flang/test/Driver/linker-flags.f90

Line 56 in 1822bc1

! MSVC-LABEL: link

not sure why wouldn't we use plain "link" instead.

But then this is quite subtle and I don't have a Windows machine to check for myself to give an informed suggestion.

Thanks for the fix, LGTM!