Skip to content

[flang] match the actual data size with the KIND (NFC) #73179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

kkwli
Copy link
Collaborator

@kkwli kkwli commented Nov 22, 2023

I think the intent is uint8_t instead of uint16_t to match logical(1). Otherwise it needs to swap byte for the big endian environment.

I have a question regarding this test. What will the corresponding Fortran construct look like for MatmulTranspose(result, *yLog, *vLog, ...)? It seems that we are doing

transpose(matrix( 3 by 2 )) * matrix( 1 by 3 )

@kkwli kkwli requested review from tblah and klausler November 22, 2023 22:18
@kkwli kkwli self-assigned this Nov 22, 2023
@llvmbot llvmbot added the flang Flang issues not falling into any other category label Nov 22, 2023
@kkwli kkwli merged commit a599a61 into llvm:main Dec 6, 2023
@kkwli kkwli deleted the matmul-transpose-test branch December 6, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flang Flang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants