-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[X86][AVX10] Allow AVX10 use VBMI2 instructions #73276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1970,20 +1970,24 @@ X86TargetLowering::X86TargetLowering(const X86TargetMachine &TM, | |
} | ||
|
||
if (Subtarget.hasVBMI2()) { | ||
for (auto VT : { MVT::v8i16, MVT::v4i32, MVT::v2i64, | ||
MVT::v16i16, MVT::v8i32, MVT::v4i64, | ||
MVT::v32i16, MVT::v16i32, MVT::v8i64 }) { | ||
for (auto VT : {MVT::v32i16, MVT::v16i32, MVT::v8i64}) { | ||
setOperationAction(ISD::FSHL, VT, Custom); | ||
setOperationAction(ISD::FSHR, VT, Custom); | ||
} | ||
|
||
setOperationAction(ISD::ROTL, MVT::v32i16, Custom); | ||
setOperationAction(ISD::ROTR, MVT::v8i16, Custom); | ||
setOperationAction(ISD::ROTR, MVT::v16i16, Custom); | ||
setOperationAction(ISD::ROTR, MVT::v32i16, Custom); | ||
} | ||
}// useAVX512Regs | ||
|
||
if (Subtarget.hasVBMI2()) { | ||
for (auto VT : {MVT::v8i16, MVT::v4i32, MVT::v2i64, MVT::v16i16, MVT::v8i32, | ||
MVT::v4i64}) { | ||
setOperationAction(ISD::FSHL, VT, Custom); | ||
setOperationAction(ISD::FSHR, VT, Custom); | ||
} | ||
} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How about ROTL for v16i16? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good question. Actually both were set to |
||
// This block controls legalization for operations that don't have | ||
// pre-AVX512 equivalents. Without VLX we use 512-bit operations for | ||
// narrower widths. | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now
setOperationAction
is called without!Subtarget.useSoftFloat()
. I've just realized that we have this predicate on integer operations. I don't know the reasons why it is so. I assume it is used as a vector register availability predicate. If so, then we need it here as wellUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the reminder!
I think
useSoftFloat
only matters when calling toaddRegisterClass
. We don't have any chance to lower the opcode without a legal type.Anyway, I think adding
useSoftFloat
matches the conversions better, I'll add it in another patch.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solved by 006f264