Skip to content

[Flang] Fix a test case that depends on stderr output of nullptr. #73349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2023

Conversation

DanielCChen
Copy link
Contributor

This test case depends on the stderr output of a nullptr being "(null)". However, it is empty string on AIX.
This PR is to initialize the sourceFileName_ to be a specific string to avoid that.

@DanielCChen DanielCChen added the flang Flang issues not falling into any other category label Nov 24, 2023
@DanielCChen DanielCChen self-assigned this Nov 24, 2023
Copy link
Collaborator

@DavidSpickett DavidSpickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The specific filename doesn't seem to be important to the test, so this LGTM.

Copy link
Collaborator

@kkwli kkwli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@DanielCChen
Copy link
Contributor Author

DanielCChen commented Nov 24, 2023

The WindowX6\4 CI failed with

1700850812986 ********************
�_bk;t=1700850812987 UNRESOLVED: Flang :: Lower/OpenMP/declare-target-implicit-func-and-subr-cap.f90 (849 of 2420)
�_bk;t=1700850812987 ******************** TEST 'Flang :: Lower/OpenMP/declare-target-implicit-func-and-subr-cap.f90' FAILED ********************
�_bk;t=1700850812987 Exception during script execution:
�_bk;t=1700850812987 Traceback (most recent call last):
�_bk;t=1700850812987   File "C:\ws\src\llvm\utils\lit\lit\worker.py", line 76, in _execute_test_handle_errors
�_bk;t=1700850812987     result = test.config.test_format.execute(test, lit_config)
�_bk;t=1700850812987   File "C:\ws\src\llvm\utils\lit\lit\formats\shtest.py", line 29, in execute
�_bk;t=1700850812987     return lit.TestRunner.executeShTest(
�_bk;t=1700850812987   File "C:\ws\src\llvm\utils\lit\lit\TestRunner.py", line 2243, in executeShTest
�_bk;t=1700850812987     parsed = parseIntegratedTestScript(test, require_script=not script)
�_bk;t=1700850812987   File "C:\ws\src\llvm\utils\lit\lit\TestRunner.py", line 2105, in parseIntegratedTestScript
�_bk;t=1700850812987     parsed = _parseKeywords(
�_bk;t=1700850812987   File "C:\ws\src\llvm\utils\lit\lit\TestRunner.py", line 2044, in _parseKeywords
�_bk;t=1700850812987     for line_number, command_type, ln in parseIntegratedTestScriptCommands(
�_bk;t=1700850812987   File "C:\ws\src\llvm\utils\lit\lit\TestRunner.py", line 1280, in parseIntegratedTestScriptCommands
�_bk;t=1700850812987     f = open(source_path, "rb")
�_bk;t=1700850812987 OSError: [Errno 22] Invalid argument: 'C:\\ws\\src\\flang\\test\\Lower\\OpenMP\\declare-target-implicit-func-and-subr-cap.f90'

I am not sure how it is related to this PR change. I don't have a window machine to reproduce it.
Is there any way that I can re-run the CI on the agent?
I do a rebase push to trigger another CI build.

@DanielCChen DanielCChen merged commit 0247183 into llvm:main Nov 25, 2023
@DanielCChen DanielCChen deleted the cdchen_nullptr branch November 25, 2023 03:54
Guzhu-AMD pushed a commit to GPUOpen-Drivers/llvm-project that referenced this pull request Nov 30, 2023
Local branch amd-gfx ff07c6f Merged main:5ac5c0e7d100 into amd-gfx:748e3557cc2b
Remote branch main 0247183 [Flang] Fix a test case that depends on stderr output of nullptr. (llvm#73349)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flang Flang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants