Skip to content

[OpenMP][Tools] Have sort(1) not use long name parameters #73477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

brad0
Copy link
Contributor

@brad0 brad0 commented Nov 27, 2023

I noticed a few tests were failing on NetBSD. NetBSD's sort(1) does not support long name parameters unlike GNU and FreeBSD/OpenBSD/DragonFly's sort(1).

executed command: sort --numeric-sort --stable

 .---command stderr------------
 | sort: unknown option -- -
 | usage: sort [-bdfHilmnrSsu] [-k kstart[,kend]] [-o output] [-R char] [-T dir]
 |              [-t char] [file ...]
 |    or: sort -C|-c [-bdfilnru] [-k kstart[,kend]] [-o output] [-R char]
 |              [-t char] [file]
 `-----------------------------

I noticed a few tests were failing on NetBSD. NetBSD's sort(1) does not support
long name parameters unlike GNU and FreeBSD/OpenBSD/DragonFly's sort(1).

executed command: sort --numeric-sort --stable

 .---command stderr------------
 | sort: unknown option -- -
 | usage: sort [-bdfHilmnrSsu] [-k kstart[,kend]] [-o output] [-R char] [-T dir]
 |              [-t char] [file ...]
 |    or: sort -C|-c [-bdfilnru] [-k kstart[,kend]] [-o output] [-R char]
 |              [-t char] [file]
 `-----------------------------
@llvmbot llvmbot added openmp:libomp OpenMP host runtime openmp:libomptarget OpenMP offload runtime labels Nov 27, 2023
@brad0 brad0 requested a review from shiltian November 27, 2023 06:05
@brad0 brad0 requested a review from mgorny November 27, 2023 08:35
Copy link
Contributor

@shiltian shiltian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fine.

@brad0 brad0 merged commit e66876f into llvm:main Nov 27, 2023
@brad0 brad0 deleted the openmp_tools_tests_lit branch November 27, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openmp:libomp OpenMP host runtime openmp:libomptarget OpenMP offload runtime test-suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants